Switch CI workflows to libbotan-3-dev#13317
Open
tredondo wants to merge 1 commit intokeepassxreboot:developfrom
Open
Switch CI workflows to libbotan-3-dev#13317tredondo wants to merge 1 commit intokeepassxreboot:developfrom
tredondo wants to merge 1 commit intokeepassxreboot:developfrom
Conversation
libbotan-2-dev is no longer available on Ubuntu 26, breaking the apt install step in the CodeQL and Copilot setup workflows once GitHub's ubuntu-latest moves to 26.04. KeePassXC already supports Botan 3 (see CMakeLists.txt and cmake/FindBotan.cmake), and INSTALL.md already documents Botan >= 3.0.0 as a valid dependency, so no source changes are needed. snap/snapcraft.yaml is intentionally left on libbotan-2-dev because it pins base: core22 (Ubuntu 22.04), where libbotan-3-dev is not available. Fixes keepassxreboot#13297
droidmonkey
requested changes
May 5, 2026
| run: | | ||
| sudo apt update | ||
| sudo apt install --no-install-recommends build-essential cmake g++ ninja-build qtbase5-dev qtbase5-private-dev qttools5-dev qttools5-dev-tools libqt5svg5-dev libargon2-dev libkeyutils-dev libminizip-dev libbotan-2-dev libqrencode-dev zlib1g-dev asciidoctor libreadline-dev libpcsclite-dev libusb-1.0-0-dev libxi-dev libxtst-dev libqt5x11extras5-dev | ||
| sudo apt install --no-install-recommends build-essential cmake g++ ninja-build qtbase5-dev qtbase5-private-dev qttools5-dev qttools5-dev-tools libqt5svg5-dev libargon2-dev libkeyutils-dev libminizip-dev libbotan-3-dev libqrencode-dev zlib1g-dev asciidoctor libreadline-dev libpcsclite-dev libusb-1.0-0-dev libxi-dev libxtst-dev libqt5x11extras5-dev |
Member
There was a problem hiding this comment.
This needs to be updated to qt6 as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13297.
libbotan-2-devis no longer available on Ubuntu 26, which will also break theapt installstep in the CodeQL and Copilot-setup workflows once GitHub'subuntu-latestrolls forward to 24.04+ / 26.04. KeePassXC already supports Botan 3 andINSTALL.mdalready documentsbotan (>= 2.12.0 or >= 3.0.0), so no source or user-facing doc changes are needed.snap/snapcraft.yamlis intentionally left onlibbotan-2-dev/libbotan-2-19because it pinsbase: core22(Ubuntu 22.04), wherelibbotan-3-devis not available.Files changed
.github/workflows/codeql.yml.github/workflows/copilot-setup-steps.ymlTesting
Locally verified that
libbotan-3-dev(3.10.0) satisfiesFindBotan.cmake. Build succeeded.AI disclosure
Per
CONTRIBUTING.md: drafted with assistance from Claude Opus 4.7. I reviewed both single-character changes.