Conversation
- Rearranged links in _sidebar.md for better organization. - Updated index.html title and meta description for improved SEO. - Corrected minor grammatical errors and improved phrasing in README.md and other documentation files. - Enhanced clarity in Getting_Started_Overview.md and Troubleshooting_Install.md. - Adjusted formatting and descriptions in various sections for better readability.
Update documentation for clarity and consistency
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| textformat.secondary_format.clear_text_format() | ||
| def run(self, event_content): | ||
| pronunciation = event_content["pronunciation"] | ||
| _apply_format(pronunciation) |
There was a problem hiding this comment.
FormattingHook.run receives event object, not dict
High Severity
FormattingHook.run was changed to expect a dict (event_content["pronunciation"]), but HooksRunner.execute still passes a RuleActivationEvent object via hook.run(event). RuleActivationEvent has .rule_class_name and .active attributes and doesn't support [] subscript access, so this will raise a TypeError at runtime whenever a rule activation event fires. Additionally, the deactivation branch that previously cleared text formatting when event.active is False was removed entirely.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| "%runtime_python%" -c "import sys; print('{0}.{1}'.format(sys.version_info.major, sys.version_info.minor))" > "%python_version_file%" | ||
| if not errorlevel 1 set /p existing_python_version=<"%python_version_file%" | ||
| if exist "%python_version_file%" del /q "%python_version_file%" >nul 2>nul | ||
| ) |
There was a problem hiding this comment.
Batch variable expansion fails inside compound if block
Medium Severity
With DisableDelayedExpansion, %python_version_file% inside the if exist (...) block is expanded when the block is parsed — before the set command executes. Since python_version_file is undefined at parse time, it expands to empty string, so the Python output redirect and set /p read both target an empty path. existing_python_version is never populated, causing the version check on the next line to always fail and the venv to be needlessly recreated on every re-run.
Additional Locations (1)
1 participant
Note
Medium Risk
Touches Windows install/launch scripts and dependency detection logic, which can break end-user setup flows if interpreter/venv resolution or wheel selection is wrong. Runtime behavior changes are mostly limited to which Python executable is used and optional UI dependencies (Qt).
Overview
Windows classic install flow is reworked around a repo-local
uvvirtualenv (.venv) using Python 3.12+. A newInstall_Caster_WSR.batis introduced, andInstall_Caster_Kaldi.bat/Run_Caster_Kaldi.batare rewritten to create/reuse.venv, install fromrequirements-windows-installer.txt, and launchdragonflyusing.venv\Scripts\python.exe(with clearer error handling when the venv/interpreter is missing).Kaldi install now has guided engine/model setup and better runtime configuration. The installer attempts to resolve and install the latest compatible
kaldi-active-grammarGitHub wheel (with a guarded fallback todragonfly2[kaldi]), optionally downloads/extracts a Kaldi model, and installs pronunciation dependencies; the runner adds env-based audio device selection viaCASTER_KALDI_AUDIO_INPUT_DEVICEplus extra engine options viaCASTER_KALDI_ENGINE_OPTIONS.Qt/UI and compatibility handling are updated for Python 3.12+. Qt import errors now provide actionable guidance, installers prefer
PySide6on supported 64-bit Python (best-effort for DNS/WSR), and runtime launches for HUD/settings/HMC/grid tools switch tosettings.runtime_hidden_console_binary().Dependency and packaging housekeeping.
requirements.txtno longer hard-requires Qt on Windows (marker-based), a newrequirements-windows-installer.txtis packaged viaMANIFEST.in,.venv/is ignored, and dependency checks now evaluate full PEP 508 requirements (markers/extras) and handledragonfly/dragonfly2distribution aliasing; docs and tests are updated accordingly.Written by Cursor Bugbot for commit d5057b9. This will update automatically on new commits. Configure here.