feat/search commit intent filter hardware#1902
Open
alanpeixinho wants to merge 1 commit into
Open
Conversation
alanpeixinho
force-pushed
the
feat/search-commit-intent-filter-hardware
branch
5 times, most recently
from
a413002 to
87a4ad1
Compare
* Add optional gitCommitHashes query param (comma-separated full hashes). * Backend uses matching checkouts instead of tree heads when provided. * Dashboard parses commit hash tokens for hardware search. * Dashboard search bar simple intent detection to apply smart search. One-line variant: feat(hardware): add gitCommitHashes filter and search intent for commits Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
alanpeixinho
force-pushed
the
feat/search-commit-intent-filter-hardware
branch
from
87a4ad1 to
a57a074
Compare
gustavobtflores
added
enhancement
Comment on lines
+39
to
+62
| sql, exec_params = mock_cursor.execute.call_args[0] | ||
| assert "selected_checkouts AS" in sql | ||
| assert "SELECT DISTINCT" in sql | ||
| assert "commits_list" not in exec_params | ||
|
|
||
| @patch("kernelCI_app.queries.hardware.connection") | ||
| def test_get_hardware_listing_data_commit_filter_tokens(self, mock_connection): | ||
| mock_cursor = setup_mock_cursor(mock_connection) | ||
| mock_cursor.fetchall.return_value = [] | ||
|
|
||
| get_hardware_listing_data( | ||
| start_date=datetime(2025, 11, 10), | ||
| end_date=datetime(2025, 11, 12), | ||
| origin="maestro", | ||
| commits_list=["a" * 40], | ||
| ) | ||
|
|
||
| sql, exec_params = mock_cursor.execute.call_args[0] | ||
| assert "selected_checkouts AS" in sql | ||
| assert "JOIN selected_checkouts AC ON b.checkout_id = AC.id" in sql | ||
| assert "ANY(%(commits_list)s)" in sql | ||
| assert "git_commit_tags" in sql and "&&" in sql | ||
| assert "SELECT DISTINCT" not in sql | ||
| assert exec_params["commits_list"] == ["a" * 40] |
Contributor
There was a problem hiding this comment.
I don't feel that these tests are valuable, tbh
Contributor
|
The PR introduces changes to the HardwareV1 page, which is not currently used in the dashboard. We should apply these changes to the V2 version instead. We may also consider removing this separation entirely in another PR to avoid further confusion. |
| !commitIntentTokens.some(t => | ||
| matchesCommitToken( | ||
| tree.head_git_commit_hash ?? '', | ||
| tree.head_git_commit_tags, |
Contributor
There was a problem hiding this comment.
The field sent from the backend is head_git_commit_tag not head_git_commit_tags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include an option to do commit searches on the search bar of the hardware listing page.
How to test