runtimes: fix path translation when using --device-dict#65
Merged
Conversation
roxell
requested changes
May 19, 2026
| # Render and bind the docker wrapper | ||
| def pre_run(self, tmpdir, volume=None): | ||
| if volume is None: | ||
| volume = tmpdir / "dispatcher" / "tmp" |
Collaborator
There was a problem hiding this comment.
we can probably create a new base function _resolve_volume(tmpdir, volume) since we have the same here and in podman.
Member
Author
There was a problem hiding this comment.
Good point, I missed that. Updated v2 patch
bhcopeland
force-pushed
the
fix-device-dict-volume
branch
from
53de8fa to
01845f4
Compare
In device-dict mode the bind uses dispatcher_download_dir on both the host and the container. The docker wrapper rewrote mount sources to tmpdir/dispatcher/tmp instead. This sent the wrong path to the host docker daemon. The bind failed with: bind source path does not exist: ... Pass the volume path explicitly to pre_run() so the caller decides which path the docker wrapper should use, based on the mode. This avoids the wrapper rewriting paths that are already host paths in device-dict mode. Also create the dispatcher_download_dir on the host before binding it. Co-developed-by: Anders Roxell <anders.roxell@linaro.org> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
bhcopeland
force-pushed
the
fix-device-dict-volume
branch
from
01845f4 to
f4b7a68
Compare
roxell
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In device-dict mode the bind uses dispatcher_download_dir on both the host and the container. The docker wrapper rewrote mount sources to tmpdir/dispatcher/tmp instead.
This sent the wrong path to the host docker daemon. The bind failed with:
bind source path does not exist: ...
Pass the volume path explicitly to pre_run() so the caller decides which path the docker wrapper should use, based on the mode. This avoids the wrapper rewriting paths that are already host paths in device-dict mode.
Also create the dispatcher_download_dir on the host before binding it.
Reported-by: Anders Roxell anders.roxell@linaro.org