[thai_kedmanee_mattix] Migrate keyboard from legacy/thai-uni#3926
[thai_kedmanee_mattix] Migrate keyboard from legacy/thai-uni#3926DavidLRowe merged 11 commits intokeymanapp:masterfrom
Conversation
|
Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process. Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment. |
|
|
||
| <h3>Basic Function</h3> | ||
| <p> | ||
| This keyboard follows the standard Thai Kedmanee layout. It also allows efficient input of uncommon Thai symbols. Characters are reordered while you type to ensure a consistent underlying sequence of diacritic vowels and tones, making tasks like search and replace much easier. Additional rules prevent you from typing many illegal vowel and tone sequences. This keyboard has also been optimised to take advantage of context-sensitive multiple keyboard switching capabilities in Toolbox (a flat database program) available from SIL. |
There was a problem hiding this comment.
I noticed a broken link from the help
The Toolbox download would be https://software.sil.org/toolbox/download/
But it's probably more appropriate to replace with FieldWorks
https://software.sil.org/fieldworks/download/
darcywong00
left a comment
There was a problem hiding this comment.
I only skimmed a few of the files so far. A couple questions...
| * Moved from freeware license to MIT license by permission of the author Samuel A. Mattix. | ||
| * Moved from legacy to release by [Meng-Heng](https://github.com/Meng-Heng) | ||
|
|
||
| 1.3 (2023-08-11) |
There was a problem hiding this comment.
This section was originally the legacy thai-uni keyboard, right?
Do you know what changed in version 1.3?
https://keyman.com/keyboards/thai-uni currently lists Keyboard Version 1.2
There was a problem hiding this comment.
It might've come from when I used kmc copy. It noted the 1.3 version with the Last Updated:
1.0 (2023-08-11)
----------------
* Created by Lao & Thai Language Services`
There was a problem hiding this comment.
I can't find what was updated.
2.0 (2026-03-13)
----------------
* Moved from freeware license to MIT license by permission of the author Samuel A. Mattix.
* Moved from legacy to release by [Meng-Heng](https://github.com/Meng-Heng)
1.2 (2012-05-24)
----------------
* Released for Keyman Desktop 8.0:
* Minor Revisions to On Screen Keyboard
* Revised help.
1.1 (2008-01-30)
----------------
* Released for Keyman Desktop 7.0: Public Domain.
* Created by Lao & Thai Language Services
Would you like me to change to this?
There was a problem hiding this comment.
Maybe something like:
2.0 (2026-03-13)
------------------
* Created by importing legacy thai-uni keyboard by permission of the author Samuel A. Mattix.
* Moved from legacy to release by [Meng-Heng](https://github.com/Meng-Heng)
and then the 1.2 and before.
@LornaSIL has done these before.
Co-authored-by: Darcy <darcy_wong@sil.org> Co-authored-by: Lorna <lorna_evans@sil.org>
|
I finished editing. This is now ready for reviews. |
|
@Meng-Heng I'm sorry I didn't catch this sooner, but we have a bit of a problem with the name. We already have a I think you can keep the keyboard name, but change the folder and filenames to something like |
|
I read through this Wiki to understand more about keyboard. How do we think about naming a keyboard with traditional, as in Thai Traditional or Khmer Traditional? |
I think this is a good name |
Co-authored-by: mcdurdin, LornaSIL, and darcywong00
|
Please review and approve. Thank you. |
darcywong00
left a comment
There was a problem hiding this comment.
The keyboard ID change ripples to a few more places
Co-authored-by: Darcy Wong <darcy_wong@sil.org>
Meng-Heng
left a comment
There was a problem hiding this comment.
Changing from Thai Kedmanee to Thai Kedmanee (Mattix) in other files to keep the naming consistent. @darcywong00, is this okay?
Co-authored-by: MengHeng <90595388+Meng-Heng@users.noreply.github.com>
Co-authored-by: MengHeng <90595388+Meng-Heng@users.noreply.github.com>
|
Thank you, @darcywong00, @LornaSIL, and @mcdurdin! |
|
Thanks, @Meng-Heng |
Fixes #3875
I noticed a broken link from the help:
Is this https://sildb.com/ a suitable replacement?
I can't proof if the statement above is true or not, should we keep it and change only the link, or should we remove it?
Note to self: