Skip to content

[thai_kedmanee_mattix] Migrate keyboard from legacy/thai-uni#3926

Merged
DavidLRowe merged 11 commits intokeymanapp:masterfrom
Meng-Heng:thai_kedmanee
Mar 30, 2026
Merged

[thai_kedmanee_mattix] Migrate keyboard from legacy/thai-uni#3926
DavidLRowe merged 11 commits intokeymanapp:masterfrom
Meng-Heng:thai_kedmanee

Conversation

@Meng-Heng
Copy link
Copy Markdown
Contributor

@Meng-Heng Meng-Heng commented Mar 19, 2026

Fixes #3875

I noticed a broken link from the help:

This keyboard has also been optimised to take advantage of context-sensitive multiple keyboard switching capabilities in Toolbox (a flat database program) available from SIL.

Is this https://sildb.com/ a suitable replacement?
I can't proof if the statement above is true or not, should we keep it and change only the link, or should we remove it?

Note to self:

  • * Move versions 1.1 - 1.2 to history.md
  • * Remove version history from welcome.htm and help.php
  • * Add deprecated pages

@keyman-server
Copy link
Copy Markdown
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.


<h3>Basic Function</h3>
<p>
This keyboard follows the standard Thai Kedmanee layout. It also allows efficient input of uncommon Thai symbols. Characters are reordered while you type to ensure a consistent underlying sequence of diacritic vowels and tones, making tasks like search and replace much easier. Additional rules prevent you from typing many illegal vowel and tone sequences. This keyboard has also been optimised to take advantage of context-sensitive multiple keyboard switching capabilities in Toolbox (a flat database program) available from SIL.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a broken link from the help

The Toolbox download would be https://software.sil.org/toolbox/download/

But it's probably more appropriate to replace with FieldWorks
https://software.sil.org/fieldworks/download/

Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only skimmed a few of the files so far. A couple questions...

Comment thread release/t/thai_kedmanee/HISTORY.md Outdated
* Moved from freeware license to MIT license by permission of the author Samuel A. Mattix.
* Moved from legacy to release by [Meng-Heng](https://github.com/Meng-Heng)

1.3 (2023-08-11)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section was originally the legacy thai-uni keyboard, right?

Do you know what changed in version 1.3?

https://keyman.com/keyboards/thai-uni currently lists Keyboard Version 1.2

Copy link
Copy Markdown
Contributor Author

@Meng-Heng Meng-Heng Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might've come from when I used kmc copy. It noted the 1.3 version with the Last Updated:

1.0 (2023-08-11)
----------------
* Created by Lao & Thai Language Services`

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find what was updated.

2.0 (2026-03-13)
----------------
* Moved from freeware license to MIT license by permission of the author Samuel A. Mattix.
* Moved from legacy to release by [Meng-Heng](https://github.com/Meng-Heng)

1.2 (2012-05-24)
----------------
* Released for Keyman Desktop 8.0: 
    * Minor Revisions to On Screen Keyboard
    * Revised help.

1.1 (2008-01-30)
----------------
* Released for Keyman Desktop 7.0: Public Domain.
* Created by Lao & Thai Language Services

Would you like me to change to this?

Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like:

2.0 (2026-03-13)
------------------
* Created by importing legacy thai-uni keyboard by permission of the author Samuel A. Mattix.
* Moved from legacy to release by [Meng-Heng](https://github.com/Meng-Heng)

and then the 1.2 and before.

@LornaSIL has done these before.

Comment thread release/t/thai_kedmanee/source/thai_kedmanee.kmn Outdated
Comment thread release/t/thai_kedmanee/source/thai_kedmanee.kps Outdated
@Meng-Heng
Copy link
Copy Markdown
Contributor Author

I finished editing. This is now ready for reviews.

@LornaSIL
Copy link
Copy Markdown
Contributor

@Meng-Heng I'm sorry I didn't catch this sooner, but we have a bit of a problem with the name. We already have a thai_kedmanee keyboard in legacy (it was a mobile keyboard only that is deprecated) and we can't use the same filename.

I think you can keep the keyboard name, but change the folder and filenames to something like thai (which is available) or thai_kedmanee_mattix. @darcywong00 or @mcdurdin do you have a preference for the foldername?

@Meng-Heng
Copy link
Copy Markdown
Contributor Author

I read through this Wiki to understand more about keyboard. How do we think about naming a keyboard with traditional, as in Thai Traditional or Khmer Traditional?

@mcdurdin
Copy link
Copy Markdown
Member

thai_kedmanee_mattix

I think this is a good name

@Meng-Heng
Copy link
Copy Markdown
Contributor Author

Please review and approve. Thank you.

@darcywong00 darcywong00 changed the title [thai_kedmanee] keyboard submission [thai_kedmanee_mattix] Migrate keyboard from legacy/thai-uni Mar 25, 2026
Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keyboard ID change ripples to a few more places

Comment thread release/t/thai_kedmanee_mattix/source/help/thai_kedmanee_mattix.php Outdated
Comment thread release/t/thai_kedmanee_mattix/README.md Outdated
Comment thread release/t/thai_kedmanee_mattix/source/thai_kedmanee_mattix.kmn Outdated
Comment thread release/t/thai_kedmanee_mattix/source/welcome/welcome.htm Outdated
Comment thread release/t/thai_kedmanee_mattix/source/thai_kedmanee_mattix.kvks Outdated
Co-authored-by: Darcy Wong <darcy_wong@sil.org>
Copy link
Copy Markdown
Contributor Author

@Meng-Heng Meng-Heng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from Thai Kedmanee to Thai Kedmanee (Mattix) in other files to keep the naming consistent. @darcywong00, is this okay?

Comment thread release/t/thai_kedmanee_mattix/source/help/thai_kedmanee_mattix.php Outdated
Comment thread release/t/thai_kedmanee_mattix/source/welcome/welcome.htm Outdated
Comment thread release/t/thai_kedmanee_mattix/source/welcome/welcome.htm Outdated
Comment thread release/t/thai_kedmanee_mattix/source/welcome/welcome.htm Outdated
Comment thread release/t/thai_kedmanee_mattix/source/readme.htm Outdated
Comment thread release/t/thai_kedmanee_mattix/source/thai_kedmanee_mattix.kps Outdated
Comment thread release/t/thai_kedmanee_mattix/source/thai_kedmanee_mattix.kvks Outdated
Comment thread release/t/thai_kedmanee_mattix/HISTORY.md Outdated
Comment thread release/t/thai_kedmanee_mattix/README.md Outdated
Comment thread release/t/thai_kedmanee_mattix/README.md Outdated
Comment thread release/t/thai_kedmanee_mattix/source/help/thai_kedmanee_mattix.php
Comment thread release/t/thai_kedmanee_mattix/source/help/thai_kedmanee_mattix.php Outdated
Co-authored-by: MengHeng <90595388+Meng-Heng@users.noreply.github.com>
Co-authored-by: MengHeng <90595388+Meng-Heng@users.noreply.github.com>
@Meng-Heng Meng-Heng requested a review from darcywong00 March 27, 2026 01:52
Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Meng-Heng
Copy link
Copy Markdown
Contributor Author

Thank you, @darcywong00, @LornaSIL, and @mcdurdin!

@DavidLRowe DavidLRowe merged commit 4144531 into keymanapp:master Mar 30, 2026
2 checks passed
@DavidLRowe
Copy link
Copy Markdown
Contributor

Thanks, @Meng-Heng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert laounicodebasic_on_thaikbd and thai-uni to release

6 participants