Skip to content

add basic authentication to SSE endpoint / logger plugin - #208

Open
xsalefter wants to merge 2 commits into
masterfrom
technical-support-325
Open

xsalefter wants to merge 2 commits into
masterfrom
technical-support-325

Conversation

@xsalefter

@xsalefter xsalefter commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor
  • Implements the basic auth for SSE endpoint : 2b3b824
  • Add demo : d8573ec

Copilot AI balanced review requested due to automatic review settings October 14, 2026 02:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Authentication interoperability, rate-limiter performance, and demo correctness issues remain unresolved.

5 open findings
What changed in this PR

Adds HTTP Basic authentication and rate limiting to the logger SSE endpoint, with tests and a browser demo.

Changes:

  • Registers an RBAC-backed authentication filter.
  • Adds per-IP failure rate limiting and unit tests.
  • Documents an authenticated browser SSE client.
File Description
BasicAuthFilter.java Implements authentication and rate limiting.
Activator.java Registers the filter with the logger plugin.
TestBasicAuthFilter.java Tests filter behavior.
TestBasicCredentials.java Tests credential parsing.
TestFailureRateLimiter.java Tests rate-limit behavior.
html-sse-demo.md Provides an authenticated SSE demo.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread osgi-bundles/bundles/logger/html-sse-demo.md Outdated
Comment thread osgi-bundles/bundles/logger/html-sse-demo.md Outdated
Comment thread osgi-bundles/bundles/logger/html-sse-demo.md Outdated
Copilot AI balanced review requested due to automatic review settings October 14, 2026 03:19
@xsalefter
xsalefter force-pushed the technical-support-325 branch from 9c680fd to 73a1eca Compare October 14, 2026 03:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +91 to +92
// -- Vendored EventSource/eventsource v5.1.2 (MIT License) --
// https://github.com/EventSource/eventsource
Copilot AI balanced review requested due to automatic review settings October 14, 2026 03:32
@xsalefter
xsalefter force-pushed the technical-support-325 branch from 73a1eca to d8573ec Compare October 14, 2026 03:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The vendored dependency lacks its required license notice, and documentation misstates the supported authentication paths.

6 open findings
1 resolved since last review

🧠 Review effort: Balanced

Comment thread osgi-bundles/bundles/logger/html-sse-demo.md
Comment thread osgi-bundles/bundles/logger/html-sse-demo.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants