Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Authentication interoperability, rate-limiter performance, and demo correctness issues remain unresolved.
5 open findings
btoa fails for non-Latin-1 credentials · New Duplicate message handlers append every log entry twice · New Rejects valid case-insensitive HTTP authentication schemes · New High-cardinality failures trigger repeated O(n) cleanup scans · New Authentication scope note incorrectly covers all plugin endpoints · New
What changed in this PR
Adds HTTP Basic authentication and rate limiting to the logger SSE endpoint, with tests and a browser demo.
Changes:
- Registers an RBAC-backed authentication filter.
- Adds per-IP failure rate limiting and unit tests.
- Documents an authenticated browser SSE client.
| File | Description |
|---|---|
BasicAuthFilter.java |
Implements authentication and rate limiting. |
Activator.java |
Registers the filter with the logger plugin. |
TestBasicAuthFilter.java |
Tests filter behavior. |
TestBasicCredentials.java |
Tests credential parsing. |
TestFailureRateLimiter.java |
Tests rate-limit behavior. |
html-sse-demo.md |
Provides an authenticated SSE demo. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
xsalefter
force-pushed
the
technical-support-325
branch
from
October 14, 2026 03:19
9c680fd to
73a1eca
Compare
Comment on lines
+91
to
+92
| // -- Vendored EventSource/eventsource v5.1.2 (MIT License) -- | ||
| // https://github.com/EventSource/eventsource |
xsalefter
force-pushed
the
technical-support-325
branch
from
October 14, 2026 03:32
73a1eca to
d8573ec
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The vendored dependency lacks its required license notice, and documentation misstates the supported authentication paths.
6 open findings
Clarify that authenticated Shiro sessions can bypass Basic credentials · New Include the required EventSource upstream license notice · New Update comment to reflect session-based authentication · New Document both Basic and Shiro session authentication paths · New Correct Clock package to java.time.Clock · New Include the full upstream MIT license notice
1 resolved since last review
🧠 Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Uh oh!
There was an error while loading. Please reload this page.