P0010 fix: apply Lovable consumer-review amendments (missed in #216 merge)#217
Merged
Conversation
The #216 merge took a stale PR head (pre-amendment). This applies the three fixes from the klappy.dev builder review: - kind resolution: frontmatter-primary, path-secondary (flexible across repos) - score/snippet are action-native fields outside the disclosure axis - reference-consumer table labeled today vs aspirational, verified against actual call inventory Verification expanded to 11 checks; risk mitigation adds path-derived-kind audit reporting.
Canon Quality — Frontmatter Schema ✅All 41 file(s) in Validator: |
Canon Quality —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
PR #216 merged a stale PR head (GitHub sync lag left the PR pointer at
7a5eeb0a, before the Lovable amendment commits). As a result the three consumer-review fixes never reachedmain. This PR applies them.The three fixes (from the klappy.dev builder review)
kindresolution rule — was undefined in the merged version. Now: frontmatterkind:is authoritative, path-prefix mapping is the fallback. Flexible across repos (klappy.dev, oddkit-kb, aquifer-mcp); canonical enumeration fixed, path mapping per-repo configurable.score/snippetare action-native fields — new subsection clarifying they sit outside thedisclosureaxis and are always present on search hits, so existing search consumers keep working at defaultdisclosure: [].snippet(query-matched excerpt) is explicitly distinct fromblockquote(document summary).Verification criteria 9 → 11. Risk mitigation adds path-derived-kind audit reporting.
Diff vs merged version: +29 lines (432 → 461).
Note
Low Risk
Documentation and proposal text only; no runtime, API, or consumer behavior changes in this diff.
Overview
Backfills Lovable consumer-review fixes that did not land when PR #216 merged a stale head. Updates the P0010 retrieval disclosure proposal and the session ledger—no oddkit or site code.
The contract now defines
kindas frontmatter-first with path-prefix fallback (fixed enumeration, per-repo path table). It adds action-native fields (score,snippet,total, listing order) outside thedisclosurearray so default search responses stay compatible. The klappy.dev reference table separates (today) vs (aspirational) call patterns and aligns pre/post-constraint narrative with verified inventory. Verification grows from 9 to 11 checks; risk mitigation asks the precursor frontmatter audit to surface path-derived kinds for deliberatekind:overrides.Reviewed by Cursor Bugbot for commit e870805. Bugbot is set up for automated code reviews on this repo. Configure here.