Skip to content

expose defaultMinimumVersion and getMinimumVersion#3352

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
psschwei:expose-version-again
May 5, 2026
Merged

expose defaultMinimumVersion and getMinimumVersion#3352
knative-prow[bot] merged 1 commit intoknative:mainfrom
psschwei:expose-version-again

Conversation

@psschwei
Copy link
Copy Markdown
Member

@psschwei psschwei commented May 5, 2026

based on @dprotaso's comment #3350 (comment)

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@knative-prow knative-prow Bot requested review from Cali0707 and creydr May 5, 2026 15:30
@knative-prow knative-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.85%. Comparing base (ea2b25f) to head (27f7532).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3352      +/-   ##
==========================================
- Coverage   74.88%   74.85%   -0.03%     
==========================================
  Files         189      189              
  Lines        8349     8347       -2     
==========================================
- Hits         6252     6248       -4     
- Misses       1853     1854       +1     
- Partials      244      245       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented May 5, 2026

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2026
@knative-prow knative-prow Bot merged commit 021ad70 into knative:main May 5, 2026
38 checks passed
@psschwei psschwei deleted the expose-version-again branch May 5, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants