chore: Upgrade 'windows-sys' 0.52.0 -> 0.61.2#97
Closed
Kissaki wants to merge 7 commits into
Closed
Conversation
Owner
Author
|
Two years not latest dependency version, and by pure chance you did it at the same time as me? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #96
I am not super familiar with Rust or WinAPI specifics, or these packages in particular.
I attempted to update the
windows-sysdependency and resolve consequential breakage discovered bycargo buildandcargo test. The namespace changes are fairly obvious and seem fairly safe. The other changes are argument type mismatches.I am creating this as a draft PR hoping someone with the necessary expertise can verify the changes and identify any additional potential concerns.
I did not do any testing beyond running
cargo teston my Windows 11 system.