Repository navigation
Make Refresh Build Data force the next poll instead of delaying it - #346
Merged
Merged
Conversation
…it [patch] RefreshBuildData restarted the build's timer, so ShouldUpdate went false and the next poll moved a full interval away. BuildSync now has ForceUpdate(), which makes ShouldUpdate true until the next UpdateAsync runs, after which normal interval pacing resumes. Fixes #303 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B6YhFsbKVvV6YZVxUJzexE
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B6YhFsbKVvV6YZVxUJzexE
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #303
What changed
RefreshBuildDatacalledBuildSync.ResetTimer(), which restarted the stopwatch.ShouldUpdatethen went false and the next poll moved a full interval away. This also affected the refresh after Re-run, Cancel and Trigger.BuildSyncnow hasForceUpdate(), which sets a flag that makesShouldUpdatetrue (withTimeRemainingat zero) until the nextUpdateAsync.UpdateAsyncclears the flag before it polls, so a refresh requested while an update is in flight still gets its own poll. After that, normal interval pacing resumes.ResetTimer()had no other callers and has been removed.Tests
BuildSyncRefreshTests:ForceUpdateMakesTheBuildDueOnTheNextTick: afterForceUpdate(), the build is due immediately.NormalPacingResumesAfterTheForcedUpdate: after the forced poll runs, the build waits out its interval again.ForceUpdate()restart the timer the way the old code did.ForceUpdateMakesTheBuildDueOnTheNextTickfailed, then passed again once the fix was put back.🤖 Generated with Claude Code
https://claude.ai/code/session_01B6YhFsbKVvV6YZVxUJzexE
Generated by Claude Code