Repository navigation
Keep the Azure DevOps project-not-found error instead of clearing it - #347
Merged
Merged
Conversation
…g it [patch] MakeAzureDevOpsRequestAsync called ClearStatus() after every action that returned normally, so the error UpdateRepositoriesAsync sets when an owner matches no project was wiped straight away. The wrapper now clears the status only when the action did not set one itself, and a later successful request still clears it. Fixes #304 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B6YhFsbKVvV6YZVxUJzexE
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #304
What changed
MakeAzureDevOpsRequestAsynccalledClearStatus()after every action that returned normally. So whenUpdateRepositoriesAsyncfound no project matching the owner, the error it set was cleared straight away, and the provider showed OK.BuildProvidernow countsSetStatuscalls (StatusSetCount). The wrapper compares the count before and after the action, and clears the status only when the action didn't set one itself. A later successful request still clears the error, as the issue's acceptance criteria ask.ReportProjectNotFound(OwnerName)helper, so a test can exercise it.Why not the triage comment's preferred option
The triage comment preferred returning
foundProjectout of the lambda and setting the error after the wrapper returns. That path only runs with a liveProjectClientsession (offline,VssConnection.GetClient<T>()throws, seeAzureDevOpsSessionTests), so no unit test could cover it. Changing the wrapper can be tested without a network connection. It also covers any future action that reports its own status. The cost is one counter field.Tests
AzureDevOpsStatusTests:AProjectNotFoundErrorSurvivesTheRequestThatReportedIt: the error is still set after the request returns.ALaterSuccessfulRequestClearsTheError: a later successful request returns the provider to OK.AProjectNotFoundErrorSurvivesTheRequestThatReportedItfailed (StatuswasOK), then passed again once the fix was put back.🤖 Generated with Claude Code
https://claude.ai/code/session_01B6YhFsbKVvV6YZVxUJzexE
Generated by Claude Code