fix: parenthesise a struct literal operand in a Go condition [patch]

[matt-edmondson]

Fixes #105

What was wrong

To match gofmt, GoGenerator.WriteCondition writes the clause of an if without its outer parentheses. That left a struct literal operand bare. if p == Point{1, 2} { is a Go syntax error, because Go reads Point{ in an if header as the start of the block (the composite-literal parsing ambiguity in the Go spec).

Change

• Each direct operand of a binary or unary condition now goes through a new WriteConditionOperand. It wraps any construction Go spells with braces in parentheses: if p == (Pair{1, 2}) {. gofmt keeps that form.
  • Everything else, and the gofmt-style clause, is unchanged.
• A new IsCompositeLiteral holds the brace-or-conversion rule that GenerateConstructionExpression already used. Both paths now share it, so they can't disagree.
• All three positions where a conditional becomes an if go through WriteCondition, so all three are fixed: return, assignment/variable initialiser, and the called function literal inside another expression.

Tests

New test in GoGeneratedSourceCompilesTests: ConditionComparingAgainstAStructLiteral_Compiles.

• It builds a Pair struct and three functions:
  • a return comparing against a positional literal;
  • an assignment comparing a field-named literal on the left with !=;
  • a conditional nested inside +, which lowers to the called function literal.
• It pins p == (Pair{1, 2}), runs go build ./..., and checks that gofmt -l reports nothing.
• It is inconclusive when no Go toolchain is on the path, like the other tests in this file.

With the generator change reverted, the test fails. The full suite passes: 1063 tests, 0 skipped, with Go 1.24 and gcc on the path.

🤖 Generated with Claude Code

https://claude.ai/code/session_01NfxXtpcxX8hkLYrePfHkV4

---

Generated by Claude Code

[matt-edmondson]

ci / .NET / Test on ubuntu-latest failed on f8851d2 because the runner went away, not because of a test. The log shows The runner has received a shutdown signal about 50 seconds into the test run, followed by Test run failed: A task was canceled. No test reported a failure.

Locally the full suite passes on this branch: 1063 tests, with Go 1.24 and gcc on the path. I'll re-run the failed job once, as soon as the macOS and Windows legs of this run finish.

---

Generated by Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud