Repository navigation
Double the braces in a Rust compile-time assertion message [patch] - #194
Merged
Merged
Conversation
assert! reads its message as a format string, so a message such as
"size {N} fits" was parsed as a placeholder naming N and the output
failed with E0425, and "brace {} here" failed with a missing argument.
The Rust generator now doubles { and } after escaping the message, so
the text reaches the compiler's error unchanged.
Fixes #166
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01X8BPy6trRZiUxiwJcbUGzR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #166
What changed
RustGenerator.GenerateCompileTimeAssertionpassedCompileTimeAssertion.Messagetoassert!as its second argument, and only escaped it.assert!reads that argument as a format string, so braces in the message were treated as format syntax:"size {N} fits"failed withE0425: cannot find value 'N'."brace {} here"failed with a missing positional argument.The generator now doubles
{and}after escaping. The message reaches the compiler's error text unchanged. C, C++ and Go don't use a format string here, so they are unchanged.Tests
RustGeneratorTests.CompileTimeAssertion_DoublesBracesInTheMessage: checks thatsize {N} fits, brace {} hereis written assize {{N}} fits, brace {{}} here.RustGeneratedSourceCompilesTests: the exemplar now has a second assertion with that message, and the test compiles it withrustc.With the generator change reverted, both tests fail, and
rustcreports E0425 and the missing-argument error. With the change, the full suite passes (1101/1101).🤖 Generated with Claude Code
https://claude.ai/code/session_01X8BPy6trRZiUxiwJcbUGzR
Generated by Claude Code