Write a Go constant holding NaN or an infinity as a var [patch]

[matt-edmondson]

Fixes #160

What changed

Since #147, the Go generator writes a non-finite double as a function call: math.NaN() or math.Inf(±1). IsCompileTimeValue still counted every float and double literal as a value a Go const can hold. As a result, a constant field or local set to NaN or ±Inf was written as const X = math.NaN(), which go build rejects with "is not constant".

GoGenerator.IsConstant now also returns false for a NaN or infinite double or float literal. Those declarations fall back to var, with the existing "a Go const is…" note. The shared IsCompileTimeValue is not changed. C# uses it too, and const double x = double.NaN; is valid C#.

The float case is included now, as the issue asks. Once #159 gives non-finite floats a real spelling, the Go form float32(math.NaN()) will be a call too.

Tests (NonFiniteDoubleLiteralTests)

• GoConstantNonFiniteValue_IsAVar: a constant static field set to NaN is written as var Unset float64 = math.NaN(), and a constant local set to +Inf as var ceiling float64 = math.Inf(1).
• GeneratedGoConstants_Compile: runs go build on the same file.

With the generator change reverted, both tests fail, and go build reports math.NaN() … is not constant and math.Inf(1) … is not constant. With the change, the full suite passes (1102/1102).

🤖 Generated with Claude Code

https://claude.ai/code/session_01X8BPy6trRZiUxiwJcbUGzR

---

Generated by Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud