Repository navigation
Make the editor gallery readable and the sample document honest - #203
Merged
Merged
Conversation
Render the graph pictures on a 2560x1440 display with a wider canvas so node text is legible, crop the side-column pictures to pane boundaries (no border sliver, no clipped Members/Settled panes, no empty space under the code), keep the layout-tuning pane whole, and crop the file menu to its own edge. Label the File menu's Path box ahead of the field, with a hint, instead of a trailing "Path" that read as nothing. Declare the sample document's fields as FieldDeclaration rather than VariableDeclaration, so Go and C note their defaults and Python writes annotated class fields; the bare member references in the method bodies are #141, which the Python caption now says. Show editing-a-document.png as the README's preview. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WWRBkw7bXdWGzuLpqnCvrB
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt in a Claude project thread.
Before: the two graph pictures were rendered so small that the node text could not be read. The side-column crops had three problems:
The layout-tuning pane was cut in two. The file-menu crop was ragged, and its Path box was an unlabelled field with "Path" trailing after it. The sample document declared its fields as
VariableDeclaration, so the generated output was wrong in two places:step = 1.The README linked the gallery as text only.
After: the graph pictures are readable, and every crop ends on a pane boundary. The Go listing fits within its picture, and the layout pane is shown whole. The file menu has a labelled Path box with a hint, and the README shows
editing-a-document.pngas its preview.The sample now uses
FieldDeclaration. With it, Go and C note each field's default, Python writescount: int = 0, and C#, C++ and JS keep the initialisers. The barecount/stepin the method bodies are not changed here: the AST cannot yet say "this instance's field" (#141). The Python caption now says so instead of implyingself.count.Two things are left alone:
AstGraph.SpareVariadicPins).Filed separately: #202. Rust drops a field's initial value silently when the type has no constructor, while Go and C note it.
How:
tests/Coder.Editor.UITests/Gallery):GalleryEntry.Displaylets an entry use its own display size; the graph pictures use 2560x1440 withGraphSplit0.66.EditorUnderTest.SideColumn(from, to)crops to the divider positions (PaneBoundary).CoderEditorApp.NewDocument, andCoderEditorAppTestsis updated to match.Coder.Testpasses (1115 tests), and the gallery suite rendered and was checked by eye. PNGs are not committed; the gallery job regenerates them on main.🤖 Generated with Claude Code
https://claude.ai/code/session_01WWRBkw7bXdWGzuLpqnCvrB
Generated by Claude Code