Repository navigation
Keep changelog subjects and authors intact when a commit subject contains '|' - #155
Merged
Merged
Conversation
…ains '|' GetCommitsAsync asked git for "%h|%s|%aN" and split on '|', so a subject such as "Support a|b syntax" became the subject "Support a" with the author "b syntax". That corrupted the changelog, the NuGet release notes and the GitHub release body, and made the bot-commit filter misjudge the commit. Separate the fields with the ASCII unit separator (%x1f), which cannot appear in a subject or an author name. Fixes #154 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T3Dc4pH8DW9RqEzV5znBXQ
|
This was referenced Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154
What was wrong
GitService.GetCommitsAsyncasked git for%h|%s|%aNand split each line on|. A subject such asSupport a|b syntaxwas parsed as subjectSupport awith authorb syntax. That corrupted the CHANGELOG, the NuGet release notes and the GitHub release body. It also madeChangelogGenerator.IsBotCommitmisjudge the commit in both directions.Change
%h%x1f%s%x1f%aN, and lines are split on'\u001f', the ASCII unit separator. That character cannot appear in a subject or an author name.GetCommitsAsync_PipeInSubject_KeepsSubjectAndAuthorIntactandGetCommitsAsync_AsksGitForUnitSeparatedFields.Verification
dotnet test: 743 passed, 0 failed.GitService.cschange reverted, 4GitServiceTestsfail, including the new pipe-in-subject test.git log -1 --pretty=format:"%h%x1f%s%x1f%aN"emits byte0x1Fbetween the fields.🤖 Generated with Claude Code
https://claude.ai/code/session_01T3Dc4pH8DW9RqEzV5znBXQ
Generated by Claude Code