Repository navigation
Match template links to repositories ignoring case, as GitHub does - #227
Merged
Merged
Conversation
FindRetired looked repositories up with a case-sensitive dictionary, so a working link such as github.com/ktsu-dev/semantics was reported as archived or no longer public, and the whole profile readme run failed. Look names up with StringComparer.OrdinalIgnoreCase, as FindLinkedRepositories already does. Fixes #163 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CzB8uCZc7DWCamHvE3Qk4k
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163
What changed
TemplateLinks.FindRetiredbuilt its lookup with the default case-sensitive comparer. A working template link such ashttps://github.com/ktsu-dev/semanticstherefore didn't match the repositorySemantics. It was reported as "archived or no longer public", andProfileGenerator.CheckTemplateLinksAsyncfailed the wholeprofile readmerun. The lookup now usesStringComparer.OrdinalIgnoreCase, which matches howFindLinkedRepositoriesand GitHub itself treat names. This is the approved fix from the decision comment.Tests
FindRetired_DoesNotFlagALinkInOtherCasing: this is the repro from the issue, a lower-case link to a liveSemanticsrepo, and it expects no retired entries. It fails onmain: I reverted the fix and saw it fail.FindRetired_FlagsAnArchivedRepositoryLinkedInOtherCasing: an archived repository linked in different casing is still flagged, so ignoring case doesn't hide real offenders.TemplateLinks.cs:39was already there.🤖 Generated with Claude Code
https://claude.ai/code/session_01CzB8uCZc7DWCamHvE3Qk4k
Generated by Claude Code