Repository navigation
Show the last completed ci.yml run in the profile Status column - #229
Merged
Merged
Conversation
GetLatestWorkflowRunAsync asked for the newest run without a status filter, so a queued or in-progress run came back with no conclusion and the badge read "unknown" until the next regeneration. The query now asks only for completed runs. Fixes #161 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WyG38ppCkkDDCmkSnea826
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161
What changed
GitHubApiClient.GetLatestWorkflowRunAsyncnow adds&status=completedto the workflow-runs query. Before this change, when a repository's newestci.ymlrun onmainwas still queued or in progress at the time the profile README job ran, the API returned that run withconclusion: null, and the Status badge read unknown until the next regeneration. It now shows the result of the most recent run that finished.This is the change the maintainer approved on the issue. The optional explicit labels for
skipped,timed_outand similar are left out.Tests
GetLatestWorkflowRunAsync_SkipsRunsThatHaveNotCompleteduses a fakegh apithat returns an in-progress run when the query has nostatus=completed, and a completedfailurerun when it does. The test checks that the client reports the failure.With the fix reverted, the new test fails. With the fix in place, the full suite passes (765/765).
🤖 Generated with Claude Code
https://claude.ai/code/session_01WyG38ppCkkDDCmkSnea826
Generated by Claude Code