Repository navigation
Point the app gallery at the repository's docs/gallery - #489
Merged
Merged
Conversation
The test host resolves a relative PROJECTDIRECTOR_GALLERY_OUT against its own bin directory, so the gallery job wrote the pictures there and then failed to find docs/gallery to commit. Pass the absolute path, as the other ktsu galleries do. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WWRBkw7bXdWGzuLpqnCvrB
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt in a Claude project thread.
Before: the gallery job that runs after CI on main failed with
fatal: pathspec 'docs/gallery' did not match any files. The pictures were rendered, but into the test host's bin directory.After: the pictures land in the repository's
docs/gallery, where the job commits them.The test host resolves a relative
PROJECTDIRECTOR_GALLERY_OUTwithPath.GetFullPath, which is relative to its own bin directory rather than the checkout.How: the workflow now passes
${{ github.workspace }}/docs/gallery, the same form the ThemeProvider, Schema, BuildMonitor, Coder and Osculator gallery workflows use. I checked it locally by running the gallery tests with the absolute path: all 7 passed and the six pictures plusREADME.mdwere written todocs/gallery.🤖 Generated with Claude Code
https://claude.ai/code/session_01WWRBkw7bXdWGzuLpqnCvrB
Generated by Claude Code