Repository navigation
Tidy the app gallery: crop, empty panel and stray glyph - #490
Merged
Merged
Conversation
Crop every picture at the bottom of the top zone, which the app now marks as a probe region, instead of one pixel above the log, which left the splitter and the log's border as a strip along the bottom. Open the two File menu dialogs over a selected repository so they are not seen against an empty panel, and fold the git actions away before propagating so the centred popup no longer lands across the similar repositories table with the tops of its digits showing above the title bar. Collapsing headers are marked so a stage can click them. The README now shows a preview from the gallery. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WWRBkw7bXdWGzuLpqnCvrB
The compare browser told directories apart by a trailing separator on each entry, but a RelativePath drops it, so no entry ever matched: every directory was listed among the files and could not be opened. Both browsers now ask the file system through ListBrowserDirectories, covered by BrowserDirectoryTests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WWRBkw7bXdWGzuLpqnCvrB
The listing's entries already include the browsed directory (see #440), so joining the browse path again looked for src/src/Inner and missed every nested directory. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WWRBkw7bXdWGzuLpqnCvrB
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Path.Combine drops every earlier argument when a later one is rooted, which CodeQL flagged on each call in BrowserDirectoryTests. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WWRBkw7bXdWGzuLpqnCvrB
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt in a Claude project thread.
Before: every gallery picture ended with a 12px strip of the log splitter and the log's border along the bottom. The two File menu dialogs sat over an empty right panel because nothing was selected. In propagating-a-file, the centred popup landed across the similar repositories table, so a stray "(" from the digits showed above its title bar. The README linked the gallery only as text. Separately, an app bug showed in comparing-two-repositories: the compare browser listed
srcand.gitamong the files. It recognised directories by a trailing separator thatRelativePathstrips, so no entry was ever a directory and folders could not be opened (#440 part a).After: each picture ends exactly on the top panel's bottom border. The dialogs open over Alpha with its details showing. The propagate popup sits in clear space below the table. The README shows comparing-a-file.png as a preview linking to the gallery. Both browsers now list directories first and open them.
How:
ShowTopPanelmarks its zone window as theTopPanelprobe region, andAboveTheLogcrops to it. Collapsing headers are markedpanel/<name>, so the propagate stage can fold Git Actions away before right-clicking.OpenMenuItemselects Alpha first. App fix: the newListBrowserDirectoriesasks the file system, joining each entry to the repository root because entries already include the browsed path. Both browsers use it, and the regression test isBrowserDirectoryTests, which also covers a nested entry. This does not fix the rest of #440 (the duplicated browse path in navigation and Give/Take). I rendered the gallery locally and checked it by eye; the gallery job regenerates the PNGs after merge.Filed rather than fixed: #491 (the diff marks padding rows with "-"; hunks are indented unevenly), #492 (the browsers list
.gitwith copy, propagate and delete actions).🤖 Generated with Claude Code
https://claude.ai/code/session_01WWRBkw7bXdWGzuLpqnCvrB
Generated by Claude Code