Repository navigation
Fix the editor's unit minus and warning colour, and tighten the gallery - #270
Merged
Merged
Conversation
- Draw a unit's superscript minus (U+207B) as a raised bar when the font has no glyph for it; the bundled JetBrains Mono NF lacks it, so s⁻¹ drew as s?¹ in the unit button, its tooltip and the unit picker. - Colour the "Warning"/"Error" label text with SeverityText rather than the frame colour, which drew it near-invisible on a dark background; the same for the code generator's save prompt. - Gallery: photograph at 1480x620 (1480x800 for the theme browser) so frames are not mostly empty, widen the left pane so its tab labels are whole, seed a recent file so Open Recent is enabled, and crop the File menu picture to the menu. - README: show member-metadata.png as the gallery preview. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WWRBkw7bXdWGzuLpqnCvrB
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt in a Claude project thread.
Before: unit symbols with a negative exponent drew as
s?¹, because the bundled JetBrains Mono NF has every superscript digit but no U+207B. This happened in the real editor as well as in the gallery. The "Warning" label in the diagnostics list was close to invisible on the dark theme, because its text was given the frame colour. The gallery frames were 1440x900 and mostly empty. The left pane cut off its tab labels, and Open Recent was disabled in "Starting a schema".After: wherever the font lacks the superscript minus, the editor draws it as a raised bar (U+00AF), in the unit button, its tooltip and the unit picker. Once the font has the real glyph, it is drawn instead. The schema file is untouched. Warning and Error labels use
EditorTheme.SeverityText, as does the code generator's save prompt, which had the same bug. Gallery pictures are now 1480x620 (1480x800 for the fixed-size theme browser). The left pane takes 27%, so every tab label is shown whole. A recent file is seeded before the File menu is photographed, and that picture is cropped to the menu. The README showsmember-metadata.pngas the gallery preview.How:
Schema.Editor/UnitText.csasks the current font withIsGlyphInFont.UnitTextTestsis a regression test. It checks that the minus drawn is one the font has, and fails when the substitution is removed (mutation-checked).Not changed: the partly visible last row in the pickers. It comes from ImGui's default list-box height (7.25 rows) inside
ktsu.ImGui.Popups, which lives in ImGuiApp rather than here. It is also ImGui's own hint that the list scrolls.Feature correctness (each picture checked against the sample schema):
GallerySchema.SearchableListchange in ImGuiApp.Floatwith no quantity, so the full unit list is the right offer, andm/sis preselected.🤖 Generated with Claude Code
https://claude.ai/code/session_01WWRBkw7bXdWGzuLpqnCvrB
Generated by Claude Code