Repository navigation
[patch] Strip every trailing separator when canonicalizing a path - #404
Merged
Merged
Conversation
SemanticPath.MakeCanonical removed at most one trailing directory separator, so "/home/user/a//" canonicalized to "/home/user/a/". That was not equal to "/home/user/a", and IsChildOf reported it as a child of itself. The trim now loops until the path ends in a non-separator or is a root, so "//" and "C:\\" still canonicalize to the root. Fixes #308 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Co2rZq6e7TjwF2FMUzNoXu
|
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #308
What was wrong
SemanticPath.MakeCanonicalremoved only one trailing directory separator, although its doc says "Removes trailing directory separators". As a result,/home/user/a//canonicalized to/home/user/a/. That didn't equal/home/user/a, andPathContainment.IsStrictlyInsidesaw a longer path followed by a separator, soIsChildOfreported the directory as inside itself.Change (
Semantics.Paths/SemanticPath.cs)ifis now a loop that trims separators until the path ends in a non-separator or is a root. It still stops at the root, so//canonicalizes to/andC:\\toC:\.PathContainmentis unchanged. Containment is now correct without it because both sides are canonical. The issue suggested a change there as optional defense in depth, but it isn't needed to fix this bug, so I left it out.Tests (
PathContainmentTests)RepeatedTrailingSeparators_CanonicalizeToTheSameDirectory, with 2 and 3 separators: the path canonicalizes to the plain spelling, equals it, and neither path is a child or parent of the other.RootWithRepeatedTrailingSeparators_StaysTheRoot: the root followed by two more separators canonicalizes to the root and is not a child of it.Semantics.Testsuite passes: 1483 passed, 0 failed, 8 skipped.Semantics.Pathsbuilds for every target framework with no warnings.🤖 Generated with Claude Code
https://claude.ai/code/session_01Co2rZq6e7TjwF2FMUzNoXu
Generated by Claude Code