Repository navigation
Fix natural numeric ordering for chunks beyond Int32 range - #42
Merged
matt-edmondson merged 2 commits intoSep 13, 2026
Merged
Conversation
Co-authored-by: matt-edmondson <19528727+matt-edmondson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix numeric chunk ordering in NaturalStringComparer
Fix natural numeric ordering for chunks beyond Int32 range
Sep 13, 2026
matt-edmondson
marked this pull request as ready for review
September 13, 2026 11:53
|
matt-edmondson
deleted the
copilot/fix-naturalstringcomparer-numeric-order
branch
September 13, 2026 12:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



NaturalStringComparertreated large digit runs as plain strings whenint.TryParseoverflowed, which inverted ordering for values like9999999999vs10000000000. This change makes numeric chunk comparison size-unbounded and adds a regression case at the Int32 boundary.Comparer logic
int.TryParse-based numeric comparison with digit-chunk comparison that:Regression coverage
Compare_LargeNumbers_HandledCorrectlywith a boundary-crossing case:"file9999999999"sorts before"file10000000000".