Add static version mapping for EOL Kubernetes releases#6150
Add static version mapping for EOL Kubernetes releases#6150willie-yao wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
willie-yao
force-pushed
the
resolve-old-releases
branch
from
4550ca8 to
64d26d5
Compare
k8s-ci-robot
added
size/S
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6150 +/- ##
=======================================
Coverage 44.43% 44.43%
=======================================
Files 280 280
Lines 25367 25367
=======================================
Hits 11272 11272
Misses 13283 13283
Partials 812 812 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scripts/ci-entrypoint.sh
Outdated
| EOL_VERSION="$(capz::util::get_eol_k8s_version "${KUBERNETES_VERSION}" || true)" | ||
| if [[ -n "${EOL_VERSION}" ]]; then | ||
| echo "EOL Kubernetes version detected, using release ${EOL_VERSION}" | ||
| export KUBERNETES_VERSION="${EOL_VERSION}" |
There was a problem hiding this comment.
I think we need to export this as CI_VERSION not KUBERNETES_VERSION
There was a problem hiding this comment.
I was setting it as KUBERNETES_VERSION here because if we're testing with a pinned version, it would make more sense to just use the normal cluster-template-prow since we're not testing any pseudo-versions. However this would break with the existing test-infra configuration because it is hard-coded to the prow-ci-version template: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-presubmit-1.31.yaml#L76
I'll just set it to CI_VERSION as it should still work it'll just have extra steps with replacing binaries
willie-yao
force-pushed
the
resolve-old-releases
branch
from
64d26d5 to
9e2e447
Compare
|
/test pull-cluster-api-provider-azure-conformance |
|
/retest |
Signed-off-by: William Yao <william2000yao@gmail.com>
willie-yao
force-pushed
the
resolve-old-releases
branch
from
9e2e447 to
205141e
Compare
|
@willie-yao: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Conformance custom builds should be fixed by #6148 |
3 participants
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
This PR fixes issues with finding releases for LTS kubernetes versions
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: