Skip to content

chore: add liveness & readiness probes to the container#84

Open
fmuyassarov wants to merge 1 commit intokubernetes-sigs:mainfrom
Nordix:devel/liveness-readiness
Open

chore: add liveness & readiness probes to the container#84
fmuyassarov wants to merge 1 commit intokubernetes-sigs:mainfrom
Nordix:devel/liveness-readiness

Conversation

@fmuyassarov
Copy link
Member

Add HTTP probes against /healthz on port 8080.
Verified locally:

kubectl debug -it dracpu-kg258  -n kube-system --image=curlimages/curl --target=dracpu -- curl -v http://localhost:8080/healthz
Targeting container "dracpu". If you don't see processes from this container it may be because the container runtime doesn't support this feature.
--profile=legacy is deprecated and will be removed in the future. It is recommended to explicitly specify a profile, for example "--profile=general".
Defaulting debug container name to debugger-97wnz.
* Host localhost:8080 was resolved.
* IPv6: ::1
* IPv4: 127.0.0.1
*   Trying [::1]:8080...
* Established connection to localhost (::1 port 8080) from ::1 port 36230
* using HTTP/1.x
> GET /healthz HTTP/1.1
> Host: localhost:8080
> User-Agent: curl/8.18.0
> Accept: */*
>
* Request completely sent off
< HTTP/1.1 200 OK
< Date: Fri, 13 Mar 2026 03:16:51 GMT
< Content-Length: 0
<
* Connection #0 to host localhost:8080 left intact

Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@est.tech>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fmuyassarov
Once this PR has been reviewed and has the lgtm label, please assign pravk03 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 13, 2026
@k8s-ci-robot k8s-ci-robot requested a review from snorwin March 13, 2026 03:24
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 13, 2026
@fmuyassarov
Copy link
Member Author

/cc @AutuSnow

@k8s-ci-robot k8s-ci-robot requested a review from AutuSnow March 13, 2026 03:25
@AutuSnow
Copy link
Contributor

Since we haven't set up a startupProbe, I'm wondering if there might be scenarios where the discovery of CPU resources on nodes takes a long time, resulting in an insufficient tolerance window for initialDelaySeconds? But unexpectedly, it seems to be working fine

@AutuSnow
Copy link
Contributor

Thank you for your revision
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2026
@fmuyassarov
Copy link
Member Author

Since we haven't set up a startupProbe, I'm wondering if there might be scenarios where the discovery of CPU resources on nodes takes a long time, resulting in an insufficient tolerance window for initialDelaySeconds? But unexpectedly, it seems to be working fine

Yes, I think we'll need to revisit the timeouts once we have some/more feedback. For now, though, it seems sufficient.

@fmuyassarov
Copy link
Member Author

/cc @ffromani

@k8s-ci-robot k8s-ci-robot requested a review from ffromani March 13, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants