Skip to content

fix(cache): release RBCache mutex lock before sending notifications (v0.3.119)#829

Closed
matthyx wants to merge 1 commit into
mainfrom
fix/cache-deadlock-oom-v0.3.119
Closed

fix(cache): release RBCache mutex lock before sending notifications (v0.3.119)#829
matthyx wants to merge 1 commit into
mainfrom
fix/cache-deadlock-oom-v0.3.119

Conversation

@matthyx
Copy link
Copy Markdown
Contributor

@matthyx matthyx commented May 29, 2026

Backport of deadlock fix to v0.3.119. Releases the RBCache mutex lock before sending rule-binding notifications to channels in AddHandler, ModifyHandler, and DeleteHandler. This resolves the RBCache deadlock which blocks all event processing workers and results in unbounded memory growth (OOM).

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@matthyx, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 8 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3a57f629-7b79-4bd5-bd4a-800988dbb83e

📥 Commits

Reviewing files that changed from the base of the PR and between eb5d48e and 590d16a.

📒 Files selected for processing (1)
  • pkg/rulebindingmanager/cache/cache.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cache-deadlock-oom-v0.3.119

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@matthyx matthyx closed this May 29, 2026
@github-actions
Copy link
Copy Markdown

Performance Benchmark Results

Node-Agent Resource Usage
Metric BEFORE AFTER Delta
Avg CPU (cores) 0.217 0.201 -7.7%
Peak CPU (cores) 0.234 0.208 -11.2%
Avg Memory (MiB) 334.347 272.344 -18.5%
Peak Memory (MiB) 336.680 281.555 -16.4%
Dedup Effectiveness

No data available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant