Repository navigation
Conversation
sa.JSON uses bind_processor rather than process_bind_param, so the AttributeError fallback treated decrypted JSON as a dict constructor argument. Serialize and parse with json instead, matching JSONType.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EncryptedType/StringEncryptedTypewithsqlalchemy.types.JSONraisedValueError: dictionary update sequence element #0 has length 1; 2 is requiredon read.sa.JSONhas noprocess_bind_param/process_result_value(it uses dialect processors), so the AttributeError fallback calleddict(json_string). OnlyJSONTypewas handled viajson.dumps/json.loads.sqlalchemy.types.JSON(and subclasses such as dialect JSON/JSONB) likeJSONTypefor encrypt/decrypt serialization.Test plan
ValueError).pytest tests/types/test_encrypted.py::TestSqlalchemyJsonEncryptedType— 4 passed (dict and list payloads ×StringEncryptedType/EncryptedType).pytest tests/types/test_encrypted.py::TestAesEncryptedTypeWithPKCS5Padding— 13 passed (includes existingJSONTypecoverage).pytest tests/types/test_encrypted.py::TestFernetEncryptedTypeTestCase::test_json— passed.