Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #798.
EnrichedDateTimeType.process_literal_paramcurrently returns the original value instead of using the existing datetime conversion. With Arrow values, dialect-specific DateTime literal processors can fail to compile the expression. With aware datetime values, the literal can also bypass the UTC conversion used by bound parameters.Reuse
process_bind_paramso the underlying DateTime literal processor receives the same converted datetime as normal parameter binding. This also keeps Pendulum literal compilation consistent with its existing bind behavior.Regression coverage:
• ArrowType and EnrichedDateTimeType with Arrow processing.
• Arrow/Pendulum objects, native aware datetime values, and supported ISO strings.
• Both timezone settings and SQLite, PostgreSQL, MySQL, and MSSQL dialect compilation; no live servers required for these cases.
• 48 Arrow cases and 24 Pendulum cases fail before the fix and pass afterward.
Verification: 95 tests passed across the four affected datetime type test files; 3 PostgreSQL-dependent tests were deselected because no PostgreSQL server was available. Ruff lint, repository format check, and diff check passed. The complete database-backed suite was not run, and the issue-specific Firebird dialect was not tested locally.