fix: use namePrefix-compatible name for ClusterRole#8
Open
lukacsi wants to merge 1 commit intol7mp:masterfrom
Open
fix: use namePrefix-compatible name for ClusterRole#8lukacsi wants to merge 1 commit intol7mp:masterfrom
lukacsi wants to merge 1 commit intol7mp:masterfrom
Conversation
0522580 to
038d842
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
Fix
Rename the ClusterRole source from
manager-roleto-role, matching the convention used by all other RBAC resources (-rolebinding,-account,-leader-election-role). Also update the roleRef in the ClusterRoleBinding to-role.With
namePrefix: dcontroller, kustomize now producesdcontroller-rolefor both.Commits
config/rbac/role.yamlandrole_binding.yamlchart/helm/templates/all.yamlviakustomize build(also picks up other pending source changes)Verification