Skip to content

fix: use namePrefix-compatible name for ClusterRole#8

Open
lukacsi wants to merge 1 commit intol7mp:masterfrom
lukacsi:fix/helm-rbac-name-mismatch
Open

fix: use namePrefix-compatible name for ClusterRole#8
lukacsi wants to merge 1 commit intol7mp:masterfrom
lukacsi:fix/helm-rbac-name-mismatch

Conversation

@lukacsi
Copy link

@lukacsi lukacsi commented Mar 20, 2026

Fixes #7

Fix

Rename the ClusterRole source from manager-role to -role, matching the convention used by all other RBAC resources (-rolebinding, -account, -leader-election-role). Also update the roleRef in the ClusterRoleBinding to -role.

With namePrefix: dcontroller, kustomize now produces dcontroller-role for both.

Commits

  1. fix: Rename source names in config/rbac/role.yaml and role_binding.yaml
  2. chore: Regenerate chart/helm/templates/all.yaml via kustomize build (also picks up other pending source changes)

Verification

$ kustomize build config/helm-base | grep "name:.*role"
  name: dcontroller-leader-election-role
  name: dcontroller-role
  name: dcontroller-leader-election-rolebinding
  name: dcontroller-leader-election-role
  name: dcontroller-rolebinding
  name: dcontroller-role

@lukacsi lukacsi force-pushed the fix/helm-rbac-name-mismatch branch from 0522580 to 038d842 Compare March 20, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm chart RBAC broken since Jan 10 chart rebuild

1 participant