Skip to content

feat(BlockPosSetting): Add button to set coordinates #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IceTank wants to merge 5 commits into
base: 1.21.11
Choose a base branch
from
Open

feat(BlockPosSetting): Add button to set coordinates #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
011fecf
Add button to BlockPosSetting to set coordinates to the current block…
IceTank Mar 8, 2026
3881d2b
Code cleanup
IceTank Mar 11, 2026
af6703f
Move BlockPosSetting 'Set' button infront of the TreeNode element to …
IceTank Mar 13, 2026
c814a7d
Remove duplicate setting name for BlockPosSetting inside TreeNode
IceTank Mar 13, 2026
82e461b
Merge remote-tracking branch 'origin/1.21.11' into feature/add-block-…
IceTank Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/kotlin/com/lambda/config/Setting.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,13 +230,13 @@ class Setting<T : SettingCore<R>, R>(
buttonMenu = menu
}

fun trySetValue(newValue: R) {
fun trySetValue(newValue: R, logResponse: Boolean = true) {
Copy link
Copy Markdown
Member

@beanbag44 beanbag44 Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think a logResponse parameter is required here. The button has the tooltip to explain what it does and the built-in log functionality offers an option to revert to the old value

Copy link
Copy Markdown
Contributor Author

@IceTank IceTank Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it this way because the default response in chat shows coordinates of the setting you changed

if (newValue == value) {
ConfigCommand.info(notChangedMessage())
if (logResponse) ConfigCommand.info(notChangedMessage())
} else {
val previous = value
value = newValue
ConfigCommand.info(setMessage(previous, newValue))
if (logResponse) ConfigCommand.info(setMessage(previous, newValue))
}
}

Expand Down
43 changes: 28 additions & 15 deletions src/main/kotlin/com/lambda/config/settings/complex/BlockPosSetting.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@ import com.lambda.config.Setting
import com.lambda.config.SettingCore
import com.lambda.gui.dsl.ImGuiBuilder
import com.lambda.util.BlockUtils.blockPos
import com.lambda.util.Communication.info
import com.lambda.util.extension.CommandBuilder
import com.lambda.util.world.raycast.RayCastUtils.blockResult
import net.minecraft.client.MinecraftClient
import net.minecraft.command.CommandRegistryAccess
import net.minecraft.util.math.BlockPos

Expand All @@ -38,21 +41,31 @@ class BlockPosSetting(defaultValue: BlockPos) : SettingCore<BlockPos>(
TypeToken.get(BlockPos::class.java).type
) {
context(setting: Setting<*, BlockPos>)
override fun ImGuiBuilder.buildLayout() {
inputVec3i(setting.name, value) { value = it.blockPos }
lambdaTooltip(setting.description)
}
override fun ImGuiBuilder.buildLayout() {
button("Set") {
MinecraftClient.getInstance().crosshairTarget?.blockResult?.blockPos?.let {
Copy link
Copy Markdown
Member

@beanbag44 beanbag44 Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mc from Lambda.kt over MinecraftClient.getInstance()

setting.trySetValue(it, logResponse = false)
Copy link
Copy Markdown
Member

@beanbag44 beanbag44 Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not set the settings value as it does below? value = it. That would avoid the whole overriding the command print thing in chat

setting.info("Coordinates updated")
} ?: info("No block under crosshair")
}
lambdaTooltip("Set the coordinates to the block you are currently looking at")
sameLine()
treeNode(setting.name, id = setting.name) {
inputVec3i("##${setting.name}", value) { value = it.blockPos }
}
lambdaTooltip(setting.description)
}

context(setting: Setting<*, BlockPos>)
override fun CommandBuilder.buildCommand(registry: CommandRegistryAccess) {
required(integer("X", -30000000, 30000000)) { x ->
required(integer("Y", -64, 319)) { y ->
required(integer("Z", -30000000, 30000000)) { z ->
execute {
setting.trySetValue(BlockPos(x().value(), y().value(), z().value()))
}
}
}
}
}
override fun CommandBuilder.buildCommand(registry: CommandRegistryAccess) {
required(integer("X", -30000000, 30000000)) { x ->
required(integer("Y", -64, 319)) { y ->
required(integer("Z", -30000000, 30000000)) { z ->
execute {
setting.trySetValue(BlockPos(x().value(), y().value(), z().value()))
}
}
}
}
}
}