perf(lambda-rs): Optimize event dispatch#192
Merged
Conversation
✅ Coverage Report📊 View Full HTML Report (download artifact) Overall Coverage
Changed Files in This PR
PR Files Coverage: 35.85% (199/555 lines) Generated by cargo-llvm-cov · Latest main coverage Last updated: 2026-03-12 20:10:50 UTC · Commit: |
There was a problem hiding this comment.
Pull request overview
Optimizes ApplicationRuntime event dispatch by introducing a precomputed per-category listener index, reducing per-event iteration to only components interested in the event’s category.
Changes:
- Added
event_listener_bucketandbuild_event_listener_indexhelpers to map event categories to listener buckets and precompute listeners. - Updated event dispatch to iterate only the listener indices for the current event category.
- Added unit tests covering bucket mapping, empty-mask rejection, and listener index construction.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimizes
ApplicationRuntimeevent dispatch by precomputing per-categorylistener buckets so each event is delivered only to interested components
instead of scanning the full component stack. This reduces dispatch from
O(C)per event toO(k)per event after a one-timeO(C)startup indexbuild, where
Cis total components andkis listeners for the eventcategory.
Related Issues
Changes
crates/lambda-rs/src/runtimes/application.rsconstruction
Type of Change
Affected Crates
lambda-rslambda-rs-platformlambda-rs-argslambda-rs-loggingChecklist
cargo +nightly fmt --all)cargo clippy --workspace --all-targets -- -D warnings)cargo test --workspace)Testing
Commands run:
cargo test -p lambda-rs runtimes::applicationManual verification steps (if applicable):
Screenshots/Recordings
N/A
Platform Testing
Additional Notes