fix: remove redundant pool.close() in _map_async_with_pool#2302
Merged
chenghao-guo merged 1 commit intolance-format:mainfrom Mar 21, 2026
Merged
fix: remove redundant pool.close() in _map_async_with_pool#2302chenghao-guo merged 1 commit intolance-format:mainfrom
chenghao-guo merged 1 commit intolance-format:mainfrom
Conversation
Contributor
Author
|
@chenghao-guo |
Collaborator
I see. Looks good. Thanks for reporting the bugfix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2301
The
exceptblock calledpool.close()before re-raising, but thefinallyblock unconditionally callspool.close()as well, resultingin a double-close on every exception path.
Remove the redundant call from the
exceptblock and letfinallyhandle cleanup exclusively, which is the correct pattern for
try/except/finally resource management.