[keelerm84]

Summary

ldclient_flagbuilder:value_for_all/2 replaced the variations with the single value and called variation_for_all(0, ...), but left the off variation unchanged. A new test flag is a boolean flag with off variation 1, so the built flag had one variation and an off variation of 1. When targeting was off, the off variation was out of range and the flag returned the default value instead of the value. The function is documented to return the value whether targeting is on or off.

value_for_all/2 now also sets the off variation to 0. variation_for_all/2 is unchanged. A new test in ldclient_testdata_SUITE turns targeting off after value_for_all/2 and checks that the flag evaluates to the value.

This matches the fix in launchdarkly/ruby-server-sdk#489.

_{Opened from termag}

---

Note

Overview
value_for_all/2 in the TestData flag builder now sets off variation to 0 after collapsing the flag to a single variation. Previously it only updated fallthrough via variation_for_all, so the default boolean off variation 1 stayed in place; with one variation, evaluation used the client default when targeting was off despite the docs promising the same value in both states.

A new Common Test case test_value_for_all_targeting_off turns targeting off after value_for_all and asserts the configured value is returned (not the default).

^{Reviewed by Cursor Bugbot for commit d8f8593. Bugbot is set up for automated code reviews on this repo. Configure here.}