Skip to content

fix: Include the big segments status on evaluation reasons when a flag fails to evaluate #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keelerm84 merged 1 commit into from
Nov 10, 2026
Merged

fix: Include the big segments status on evaluation reasons when a flag fails to evaluate #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/sdk/server/src/main/java/com/launchdarkly/sdk/server/Evaluator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,14 @@ EvalResult evaluate(FeatureFlag flag, LDContext context, @Nonnull EvaluationReco
return result;
} catch (EvaluationException e) {
logger.error("Could not evaluate flag \"{}\": {}", flag.getKey(), e.getMessage());
return EvalResult.error(e.errorKind);
EvalResult result = EvalResult.error(e.errorKind);
// A big segment query can run before the error occurs. Keep its status on the error reason.
if (state.bigSegmentsStatus != null) {
result = result.withReason(
result.getReason().withBigSegmentsStatus(state.bigSegmentsStatus)
);
}
return result;
}
}

Expand Down
49 changes: 49 additions & 0 deletions lib/sdk/server/src/test/java/com/launchdarkly/sdk/server/EvaluatorBigSegmentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package com.launchdarkly.sdk.server;

import com.launchdarkly.sdk.AttributeRef;
import com.launchdarkly.sdk.ContextKind;
import com.launchdarkly.sdk.EvaluationReason;
import com.launchdarkly.sdk.EvaluationReason.BigSegmentsStatus;
import com.launchdarkly.sdk.LDContext;
import com.launchdarkly.sdk.LDValue;
Expand All @@ -14,6 +16,7 @@
import static com.launchdarkly.sdk.server.Evaluator.makeBigSegmentRef;
import static com.launchdarkly.sdk.server.EvaluatorTestUtil.expectNoPrerequisiteEvals;
import static com.launchdarkly.sdk.server.ModelBuilders.booleanFlagWithClauses;
import static com.launchdarkly.sdk.server.ModelBuilders.clause;
import static com.launchdarkly.sdk.server.ModelBuilders.clauseMatchingContext;
import static com.launchdarkly.sdk.server.ModelBuilders.clauseMatchingSegment;
import static com.launchdarkly.sdk.server.ModelBuilders.flagBuilder;
Expand Down Expand Up @@ -192,4 +195,50 @@ public void bigSegmentStateIsQueriedOnlyOncePerKeyEvenIfFlagReferencesMultipleSe
assertEquals(LDValue.of(true), result.getValue());
assertEquals(BigSegmentsStatus.HEALTHY, result.getReason().getBigSegmentsStatus());
}

@Test
public void bigSegmentStatusIsIncludedWhenLaterClauseIsMalformed() {
Segment segment = segmentBuilder("segmentkey").unbounded(true).generation(2).build();
Clause malformedClause = clause(null, (AttributeRef)null, DataModel.Operator.in, LDValue.of("x"));
FeatureFlag flag = flagBuilder("key")
.on(true)
.fallthroughVariation(0)
.variations(false, true)
.rules(
ruleBuilder().variation(1).clauses(clauseMatchingSegment(segment)).build(),
ruleBuilder().variation(1).clauses(malformedClause).build()
)
.build();

// The context is not in the big segment, so evaluation continues to the malformed rule.
BigSegmentStoreWrapper.BigSegmentsQueryResult queryResult = new BigSegmentStoreWrapper.BigSegmentsQueryResult();
queryResult.status = BigSegmentsStatus.STALE;
queryResult.membership = createMembershipFromSegmentRefs(null, null);
Evaluator evaluator = evaluatorBuilder().withStoredSegments(segment).withBigSegmentQueryResult(testUser.getKey(), queryResult).build();

EvalResult result = evaluator.evaluate(flag, testUser, expectNoPrerequisiteEvals());
assertEquals(LDValue.ofNull(), result.getValue());
assertEquals(EvaluationReason.ErrorKind.MALFORMED_FLAG, result.getReason().getErrorKind());
assertEquals(BigSegmentsStatus.STALE, result.getReason().getBigSegmentsStatus());
}

@Test
public void bigSegmentStatusIsIncludedWhenLaterClauseIsMalformedAndNoProviderIsConfigured() {
Segment segment = segmentBuilder("segmentkey").unbounded(true).generation(2).build();
Clause malformedClause = clause(null, (AttributeRef)null, DataModel.Operator.in, LDValue.of("x"));
FeatureFlag flag = flagBuilder("key")
.on(true)
.fallthroughVariation(0)
.variations(false, true)
.rules(
ruleBuilder().variation(1).clauses(clauseMatchingSegment(segment)).build(),
ruleBuilder().variation(1).clauses(malformedClause).build()
)
.build();
Evaluator evaluator = evaluatorBuilder().withStoredSegments(segment).withBigSegmentQueryResult(testUser.getKey(), null).build();

EvalResult result = evaluator.evaluate(flag, testUser, expectNoPrerequisiteEvals());
assertEquals(EvaluationReason.ErrorKind.MALFORMED_FLAG, result.getReason().getErrorKind());
assertEquals(BigSegmentsStatus.NOT_CONFIGURED, result.getReason().getBigSegmentsStatus());
}
}
Loading