[keelerm84]

Summary

FlagBuilder::valueForAll replaced the variations with the single value and called variationForAll(0), but left the off variation unchanged. A new test flag is a boolean flag with off variation 1, so the built flag had variations: [value] and offVariation: 1. With targeting off, the index was out of range and the flag failed to evaluate. The method is documented to return the value regardless of whether targeting is on or off.

valueForAll now also sets the off variation to 0. variationForAll is unchanged. A new test builds a flag with valueForAll, checks that offVariation is 0, turns targeting off, and checks that LDClient::variation returns the value.

Same fix as launchdarkly/ruby-server-sdk#489.

_{Opened from termag}

---

Note

Overview
Fixes TestData FlagBuilder::valueForAll so flags still evaluate when targeting is turned off.

Previously the helper replaced variations with a single value and routed “on” traffic via variationForAll(0), but did not update offVariation. New TestData flags default to a boolean layout with offVariation index 1, so after valueForAll the built flag had one variation at index 0 while offVariation still pointed at index 1, causing bad evaluations when targeting was off—despite the doc saying the same value should apply on or off.

The change chains offVariation(0) after the existing setup. variationForAll is unchanged. A new integration test asserts offVariation is 0 and that LDClient::variation returns the configured value with targeting off.

^{Reviewed by Cursor Bugbot for commit 9fe0b55. Bugbot is set up for automated code reviews on this repo. Configure here.}