Repository navigation
fix: Include the big segments status on evaluation reasons for failed evaluations - #292
Merged
Merged
Conversation
… evaluations An error that occurs after a big segment query no longer drops the big segments status from the reason.
jsonbailey
approved these changes
Nov 10, 2026
keelerm84
pushed a commit
that referenced
this pull request
Nov 10, 2026
🤖 I have created a release *beep* *boop* --- ## [6.12.1](6.12.0...6.12.1) (2026-11-10) ### Bug Fixes * Include the big segments status on evaluation reasons for failed evaluations ([#292](#292)) ([2f2b1fe](2f2b1fe)) * Include the HTTP status in exceptions on evaluation reasons ([#291](#291)) ([52d3303](52d3303)) * Make TestData valueForAll return its value when targeting is off ([#288](#288)) ([b8a9522](b8a9522)) * Prevent allFlagsState from throwing when retrieving flags fails ([#294](#294)) ([2b65bf2](2b65bf2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a flag evaluation fails after it has queried a big segment, the evaluation reason now includes the big segments status. Before, the error reason dropped the status. For example, a later rule could reference a circular segment, or a segment lookup could throw.
The status is applied the same way as on successful evaluations. On an unexpected exception the reason keeps the exception. This matches the Go SDK, and the spec allows
bigSegmentsStatuson any reason kind.Note
Overview
When flag evaluation fails after a big-segment lookup (e.g. a later rule hits a circular segment or a missing segment throws), the returned
EvaluationReasonnow keepsbigSegmentsEvaluationStatusfrom evaluator state instead of dropping it.Error and unexpected-exception paths in
Evaluator::evaluate()route reasons through a newwithBigSegmentsStatushelper, mirroring successful evaluations and the Go SDK. Two tests assertSTALEremains on the reason for malformed-flag and lookup-throw scenarios.Reviewed by Cursor Bugbot for commit 79dfe2f. Bugbot is set up for automated code reviews on this repo. Configure here.