Skip to content

docs: Fix the getErrorKind() description - #293

Merged
keelerm84 merged 1 commit into
mainfrom
mk/fix-error-kind-docblock
Nov 10, 2026
Merged

keelerm84 merged 1 commit into
mainfrom
mk/fix-error-kind-docblock

Conversation

@keelerm84

@keelerm84 keelerm84 commented Nov 9, 2026 •

Copy link
Copy Markdown
Member

Summary

The EvaluationReason::getErrorKind() docblock said the method returns an error kind when getKind() is OFF. It returns one when getKind() is ERROR. This corrects that line. The other getter docblocks in the file were checked and are correct. No code changes.


Note

Overview
Corrects the EvaluationReason::getErrorKind() PHPDoc so it states the error kind is returned when getKind() is ERROR, not OFF. This matches how error reasons are constructed (e.g. error() / exception()) and lines up with other docs in the same class such as getException().

No runtime or API behavior changes—documentation only.

Reviewed by Cursor Bugbot for commit 1bfb45c. Bugbot is set up for automated code reviews on this repo. Configure here.

@keelerm84
keelerm84 marked this pull request as ready for review November 9, 2026 18:16
@keelerm84
keelerm84 requested a review from a team as a code owner November 9, 2026 18:16
@keelerm84
keelerm84 requested a review from kinyoklion November 9, 2026 20:33
@keelerm84
keelerm84 merged commit d9b8d04 into main Nov 10, 2026
14 checks passed
@keelerm84
keelerm84 deleted the mk/fix-error-kind-docblock branch November 10, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants