[keelerm84]

Summary

LDClient::allFlagsState() only caught UnrecoverableHTTPStatusException from the feature requester. Any other error, such as a network failure, a persistent store failure, or an exception from a custom FeatureRequester, escaped to the caller. Evaluation methods should not throw, and other SDKs return an invalid state here.

allFlagsState() now catches any Throwable from getAllFeatures(), logs it at error level, and returns an invalid FeatureFlagsState. Unrecoverable HTTP errors still take the client offline.

---

Note

Overview
LDClient::allFlagsState() no longer lets failures from FeatureRequester::getAllFeatures() bubble up. Besides UnrecoverableHTTPStatusException (still puts the client offline), it now catches any Throwable, logs via Util::logExceptionAtErrorLevel, and returns an invalid FeatureFlagsState, matching single-flag evaluation and other SDKs.

Tests cover RuntimeException / Error (invalid state, empty map, error log, client stays online) and unrecoverable HTTP on allFlagsState (client offline on later calls).

^{Reviewed by Cursor Bugbot for commit d57af57. Bugbot is set up for automated code reviews on this repo. Configure here.}