Repository navigation
Conversation
…lag key is a Symbol TestDataV2 stored a flag builder under the key that the caller passed to flag. use_preconfigured_flag discards the builder under the String key from the flag data, so it missed a builder that flag(:key) created. A later flag(:key) then returned the old builder, and update replaced the preconfigured flag with it. flag and FlagBuilderV2 now convert the key to a String. A Symbol key and a String key get the same builder, and a built flag has a String key, as a flag from LaunchDarkly has.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestDataV2 stored a flag builder under the key that the caller passed
to flag. use_preconfigured_flag discards the builder under the String
key from the flag data, so it missed a builder that flag(:key) created.
A later flag(:key) then returned the old builder, and update replaced
the preconfigured flag with it.
flag and FlagBuilderV2 now convert the key to a String. A Symbol key
and a String key get the same builder, and a built flag has a String
key, as a flag from LaunchDarkly has.
Note
Overview
TestDataV2 now normalizes flag keys to strings in
flagand inFlagBuilderV2#initialize, so a Symbol and String key refer to the same cached builder and stored flags always use a stringkey(matching LaunchDarkly).This fixes a test-data bug where building a flag with
flag(:key)left a builder under the symbol key whileuse_preconfigured_flagonly cleared the string-keyed entry—laterflag(:key)could resurrect the old builder and overwrite the preconfigured flag onupdate.Specs cover symbol/string equivalence, correct storage after updates, and a fresh default builder after preconfigured replacement when the flag was originally built with a symbol key.
Reviewed by Cursor Bugbot for commit 88a0747. Bugbot is set up for automated code reviews on this repo. Configure here.