Fix npm audit findings in TypeScript SDK packages#781
Conversation
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR updates TypeScript SDK and example application dependencies to maintain compatibility. The main SDK package.json bumps viem to ^2.50.4 and introduces an npm overrides section pinning ws to 8.21.0. Both example applications receive viem updates to ^2.50.4; app_sessions also updates ws to ^8.20.1. ChangesDependency Version Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
29c5ef5 to
366b594
Compare
Summary
viemranges so they resolvews@8.20.1.wsusage insdk/tsandapp_sessionsto the patched8.20.1release.sdk/tsso the dev-onlyethersdependency dedupes tows@8.20.1instead of keeping a vulnerable nested copy.sdk/ts/package-lock.jsondev-tool transitive dependencies sobrace-expansionresolves to5.0.6anddiffresolves to4.0.4.Validation
cd sdk/ts && npm audit --package-lock-only --jsonreports 0 vulnerabilitiessdk/ts,sdk/ts/examples/app_sessions, andsdk/ts/examples/example-appall report 0 vulnerabilitiescd sdk/ts && npm run typecheckcd sdk/ts && npm test(12 suites, 180 tests)Summary by CodeRabbit
viemdependency to version 2.50.4 across SDK and example packageswsdependency to versions 2.20.1 and 2.21.0 in example packageswsin main SDK package