fix(pipeline-console-reporter): eliminate concurrent ora spinner warnings#253
Merged
fix(pipeline-console-reporter): eliminate concurrent ora spinner warnings#253
Conversation
…ings and timer leaks - Replace printLine's temporary ora instance with log-symbols + process.stderr.write to avoid '[ora] Multiple concurrent spinners detected' warning - Capture spinner reference in importStarted() closure so the timer can't mutate a subsequent stage's spinner - Add defensive clearImportTimer() in distributionSelected's non-import branch to prevent leaks across datasets - Add log-symbols as a direct dependency (already a transitive dep of ora v9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
printLine's temporaryora()instance withlog-symbols+process.stderr.write, eliminating the[ora] Multiple concurrent spinners detectedwarning that occurred when a temp spinner'sstop()wrote to stderr during an active spinner's stream hooksimportStarted()'s timer closure (const spinner = ...) instead of referencingthis.activeSpinner, preventing the timer from mutating a subsequent stage's spinner and causing flickeringclearImportTimer()call indistributionSelected's non-import branch to prevent timer leaks across datasetslog-symbolsas a direct dependency (already a transitive dep of ora v9, produces byte-identical output)