Open
Conversation
Contributor
|
I am taking a look to this now. I might come with further instructions. |
GabrielaReyna
requested changes
May 7, 2026
Contributor
GabrielaReyna
left a comment
There was a problem hiding this comment.
Hi Sarah, thanks for taking a look at this.
I'd like for you to do the following in this PR:
- I believe some of the jars in the swingset tutorial are empty and not needed. Please test this out and get rid of unnecessary files. These changes should apply to the zip file in the tutorial, the examples folder in the cheerpj-meta repo and in the swingset3 leaning tech repo ( the one deployed and used in the tutorial iframe). If you have checked all of this, feel free to just ignore this bullet point.
- The zip files in all the tutorials of cheerpj contain the HTML file where cheerpj is loaded via the loader URL. This is a pain to update every single time there is a new version, zip back and modify the tutorials. Hence, please modify the tutorial's HTML file and replace the loader URL with "paste url here" maybe pointing to a url in the docs with the current loader URL. Please do for all the cheerpj tutorials that have a downloadable layout.
- Once the bullet point above is complete, please mention in the tutorials that the url needs to be updated.
If you have a better suggestion on how to do the above, for example, automating creating a zip that exists in the examples repo rather than in the labs repo would be amazing. But if not, the simple solution above should be enough.
Many thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a comment to the swingset3 tutorial to clarify the app we use causes harmless errors.