Repository navigation
fix(ui): clarify runtime state and page actions - #126
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The desktop console could look fully available while a requested capture change was unapplied, and connection counts could still look current after a read error. Rule cards also retained a table header that did not match their layout.
What changed
Scope
The changes cover the GPUI desktop window and its editing documentation. Routing, controller protocols, Network Extension behavior, persistence formats, and installed application configuration are unchanged. Group and rule editing use visible Edit buttons; right-click rule shortcuts remain available.
Blast Radius
Overview, connections, groups, rules, and settings are affected. A focused regression test covers TUN versus Network Extension DNS labels and unapplied state.
Verification
git diff --checkpassed.Owner: harryisfish
Status: merged; main CI passed; minimum window dimensions remain unverified