Skip to content

fix(ui): clarify runtime state and page actions - #126

Merged
harryisfish merged 8 commits into
mainfrom
fix/ui-ux-polish
Nov 14, 2026
Merged

harryisfish merged 8 commits into
mainfrom
fix/ui-ux-polish

Conversation

@harryisfish

@harryisfish harryisfish commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Why

The desktop console could look fully available while a requested capture change was unapplied, and connection counts could still look current after a read error. Rule cards also retained a table header that did not match their layout.

What changed

  • Show applied versus saved capture intent, partial readiness, and DNS ownership separately for automatic proxy and TUN. Use neutral informational messages and accessible warnings for errors or recovery steps.
  • Distinguish reported, loaded, and visible connections; avoid stale counts after errors. Clarify the built-in global selector and configured-group section.
  • Keep labelled rule actions together, open complete matcher lists from the overflow count, remove the misaligned table header, and align the editing documentation with explicit controls.

Scope

The changes cover the GPUI desktop window and its editing documentation. Routing, controller protocols, Network Extension behavior, persistence formats, and installed application configuration are unchanged. Group and rule editing use visible Edit buttons; right-click rule shortcuts remain available.

Blast Radius

Overview, connections, groups, rules, and settings are affected. A focused regression test covers TUN versus Network Extension DNS labels and unapplied state.

Verification

  • Exact-head CI passed: CI run, including Network Extension, NetworkShared, and Sparkle build.
  • 110 isolated library tests and 3 UI unit tests passed; git diff --check passed.
  • Independent source review passed. Earlier dark-theme renders verified overview, group/rule controls, and the complete matcher editor.
  • Independent review exercised the final rule cards, all 13 matcher conditions, light-theme settings, and the disconnected connections view. Visual and accessibility checks passed. Minimum window dimensions remain unverified.
  • After the squash merge, main CI passed on the merge commit.

Owner: harryisfish
Status: merged; main CI passed; minimum window dimensions remain unverified

@harryisfish
harryisfish marked this pull request as ready for review November 14, 2026 15:40
@harryisfish
harryisfish merged commit 5226125 into main Nov 14, 2026
1 check passed
@harryisfish
harryisfish deleted the fix/ui-ux-polish branch November 14, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant