Skip to content

feat-004: Account Registration & Onboarding#1

Closed
leecampbell-codeagent wants to merge 4 commits intomainfrom
ralph/feat-004-account-registration-onboarding
Closed

feat-004: Account Registration & Onboarding#1
leecampbell-codeagent wants to merge 4 commits intomainfrom
ralph/feat-004-account-registration-onboarding

Conversation

@leecampbell-codeagent
Copy link
Copy Markdown
Owner

Summary

  • Multi-step onboarding wizard (welcome → role selection → profile → preferences → completion) replacing the placeholder stub
  • Account domain entity extended with onboarding_step, role, profile fields (display_name, bio, avatar_url), and notification preferences; all mutations are immutable and emit domain events to the event store
  • Account update + event append wrapped in a shared database transaction (transactional integrity, Edge Case chore: add PR screenshots and early PRD commit/push LeeCampbell/MarsMissionFund#17)
  • API: GET /api/v1/accounts/me, PATCH /api/v1/accounts/me/onboarding, PATCH /api/v1/accounts/me, PATCH /api/v1/accounts/me/preferences
  • Frontend: OnboardingWizard with StepProgress, RoleCard, ToggleSwitch components; settings pages at /settings/profile and /settings/preferences; onboarding guard redirects users to /onboarding until complete
  • GitHub Actions CI workflow added (lint, typecheck, test with Postgres service, build, security audit)
  • 264 tests passing (136 backend + 128 frontend), build clean, 0 critical/high security findings

Quality Gate

  • Tests: 264/264 passing
  • Security: 0 critical/high findings
  • Audit: PASS (iteration 2 — 3 failures fixed: 401 tests, event payload, transactional writes)
  • Exploratory: PASS (code-review based — Docker not available in agent environment)
  • CI/CD: PASS — GitHub Actions workflow configured

Reports

  • Exploratory: .claude/reports/feat-004-exploratory.md
  • Security: .claude/reports/feat-004-security.md
  • Audit: .claude/reports/feat-004-audit.md
  • CI/CD: .claude/reports/feat-004-cicd.md

🤖 Generated with Claude Code

leecampbell-codeagent and others added 4 commits March 5, 2026 18:04
…at-004)

- Multi-step onboarding wizard (welcome, role selection, profile, preferences, completion)
- Account domain entity extended with onboarding_step, role, profile, and notification preference fields
- Domain event emission to event store on onboarding completion and profile updates
- API endpoints: GET /me, PATCH /me/onboarding, PATCH /me, PATCH /me/preferences
- PgAccountRepository updated with findById and update methods
- InMemoryEventStore and PgEventStoreAdapter implemented
- Frontend: OnboardingWizard with StepProgress, RoleCards, ToggleSwitch components
- Settings pages: /settings/profile and /settings/preferences
- Onboarding guard redirects users to /onboarding if not complete
- 260 tests passing (132 backend + 128 frontend)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add 401 unauthenticated tests for all 4 account API endpoints
- Fix preferences_updated event payload to include categories_changed array
- Wrap account update + event append in shared database transaction (Edge Case LeeCampbell#17)
- Introduce TransactionPort and PgTransactionAdapter for transactional DB operations

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Exploratory review: PASS (code-review based, all 8 US verified)
- Security review: PASS (0 critical/high findings)
- Audit: PASS (all 3 failures resolved in iteration 2)
- CI/CD: PASS — add GitHub Actions workflow (lint, typecheck, test, build, audit)
- Fix 34 lint/a11y errors: semantic HTML in onboarding components (label+input for
  radio group, section for region, output for status), biome format fixes

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@leecampbell-codeagent leecampbell-codeagent force-pushed the ralph/feat-004-account-registration-onboarding branch from 9bc3091 to 774b35a Compare March 5, 2026 10:04
@leecampbell-codeagent leecampbell-codeagent deleted the ralph/feat-004-account-registration-onboarding branch March 5, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant