Repository navigation
fix(ui): wrap prompt words without misplacing the cursor - #401
Merged
Merged
Conversation
The input and prompt echoes now use word wrapping. Cursor measurement wraps the complete line with wrap-ansi and maps source offsets through grapheme normalization and tab expansion. Inline cursor rendering highlights whole graphemes and avoids duplicate cursor cells at segment boundaries. Regression tests cover wrapping, cursor movement, resizing, and submission of the original buffer. Fixes lessweb#327
Contributor
Author
|
Appreciate the merge, @qorzj. Prompt words should now wrap onto the next line without the cursor landing in the wrong spot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Words were split across lines in the prompt input and submitted prompt echoes even when they could fit on the next line. Cursor positioning also needed to follow words moved by wrapping.
Both displays used hard wrapping. Cursor measurement counted only characters before the cursor, so it could not account for the rest of a word moving that cursor onto another row.
Summary
The input and prompt echoes now use word wrapping. Cursor measurement wraps the complete line with wrap-ansi and maps source offsets through grapheme normalization and tab expansion. Inline cursor rendering highlights whole graphemes and avoids duplicate cursor cells at segment boundaries. Regression tests cover wrapping, cursor movement, resizing, and submission of the original buffer.
Tests
npm testlocally on macOS for the deepcode-cli PromptEchoLine change; it passed.packages/cli/src/tests/message-view.test.ts,packages/cli/src/tests/prompt-input-keys.test.tsandpackages/cli/src/tests/prompt-input-wrap.test.tsfail without the fix in the deepcode-cli PromptEchoLine change (checked by reverting the source changes).Fixes #327