Repository navigation
fix: make stream idle timeout configurable - #405
Open
msamoilenko wants to merge 1 commit into
Open
msamoilenko wants to merge 1 commit into
msamoilenko wants to merge 1 commit into
Conversation
The 60s idle watchdog was hardcoded and caused false positives with thinking models. Add streamIdleTimeoutMs (default 180s, range 30s-30min) and report the effective timeout in the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The stream idle watchdog was hardcoded to 60 seconds. Thinking models can stay silent for longer than that, so valid requests were aborted and retried even when the provider was still working.
Change
streamIdleTimeoutMsto user/project settings.LlmStreamIdleTimeoutError.Verification
npm run checkpasses.session.test.ts+settings-and-notify.test.ts: 190 passing.The default changes from 60s to 180s. Users who prefer the old behavior can set
streamIdleTimeoutMs: 60000.