Repository navigation
fix: bound error log payloads and isolate test homes - #406
Open
msamoilenko wants to merge 1 commit into
Open
msamoilenko wants to merge 1 commit into
msamoilenko wants to merge 1 commit into
Conversation
Mask raw sk- keys, truncate every logged string, cap entries at 32k chars, and retain the last 50 entries. Run each package test suite with a temporary HOME so tests never write to the real ~/.deepcode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The API error log wrote full request payloads and kept only 20 entries. A session could produce multi-megabyte lines, tests wrote to the real
~/.deepcode/logs/error.log, and rawsk-keys were not masked.Change
Authorization,api_key,secret,token, and rawsk-...values.HOMEand clean it up.Verification
npm run checkpasses.~/.deepcode/logs/error.logwas unchanged before and after the suites.