Repository navigation
Conversation
This PR adds experimental support for launching virtual machines on Windows hosts using libkrun 2.0 and the Windows Hypervisor Platform (WHP). 1. Added build.rs link instructions using LIBKRUN_LIB_DIR for krun.dll.lib lookup on Windows and a build.ps1 helper script for local development on Windows. 2. Restricted timesync module to macOS only 3. Splitted context/virtio/status to have platform-specific implementations. The macOS part remained unchanged. This patch misses the firmware for x86_64 systems. It depends on slp/edk2#2 It will be added in following PR Assisted-by: OpenCode: GPT-5.6 Terra Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
Add a `--console` command-line argument for Windows builds to allow selecting the guest console device attached to the host terminal (`ttyS0` or `hvc0`). Assisted-by: OpenCode: GPT-5.6 Terra Signed-off-by: Luca Stocchi <lstocchi@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Windows builds were hardcoded to use hvc0 via the virtio-console builder. Depending on the guest kernel configuration (such as Fedora cloud images), the guest may default to outputting over a serial console (ttyS0) rather than hvc0. Providing the --console flag gives users the flexibility to match krunkit's console mapping to their guest OS kernel parameters.
This requires libkrun/libkrun#914
This is built over #116. I'll rebase this one when that gets merged