Skip to content

Include claim diagnostics in positive-selection test failures #8342

Closed

Description

@lidge-jun

Client or integration

Other

Area

Platform (Windows / macOS / Linux)

Summary

In the quota-provenance test, a claim failure in the positive-selection scenario causes the boolean selection assertion to fail before the collected sanitized diagnostics are included in the failure output.

Reproduction

  1. Inspect the verified replacement case in tests/codex-integration/main-quota-provenance.test.ts in PR Diagnose Windows native-main claim setup failures #8341.
  2. Inject an early native claim failure and observe that the selection assertion fails without including the collected diagnostic object.

Version

PR #8341 head da79890551.

Operating system

Any supported platform; diagnostics are especially useful in hosted Windows CI.

Provider and model

Not applicable.

Logs or error output

Not applicable.

Screenshots and supporting files

Not applicable.

Redacted configuration

Not applicable.

Checks

  • I searched existing issues and documentation.
  • I removed secrets, tokens, account details, request credentials, and personal data.

Activity

  1. added
    platformOS/service/tray/ACL (Windows-heavy, not Windows-only)
    on Nov 8, 2026
  2. lidge-jun commented on Nov 8, 2026

    @lidge-jun
    OwnerAuthor

    Resolved by #8345 (merged to dev as 1c97e3c). The positive-selection assertion now carries the allowlisted claim diagnostics in its failure message, and positive selection selection/exit failure reports sanitized claim diagnostics plus the forced-timeout test prove it end to end. Checked on origin/dev with isolated homes: main-quota-provenance.test.ts 52 pass, layout/ratchet/Lab guards 63 pass, typecheck and privacy scan pass. The duplicate PR #8365 is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingplatformOS/service/tray/ACL (Windows-heavy, not Windows-only)

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions