Repository navigation
fix(codex): keep the desktop app open on codex-restart when its picker is current #7149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
cfae14f
fix(codex): keep the desktop app open when its picker is current on c…
0e62812
fix(cli): report whether codex-restart kept the desktop app open
9100516
docs: describe the picker-aware codex-restart scope
aa113e7
fix(codex): judge the desktop picker against the bound catalog and re…
e57a635
Merge remote-tracking branch 'origin/dev' into lane/restart-r2-7149
01099a6
docs(codex): describe closed desktop restart outcomes
c72777b
Merge remote-tracking branch 'origin/dev' into lane/restart-r2-7149
b77323d
docs(codex): name rebinding as a desktop restart trigger
5bc093e
docs(cli): include rebinding in Codex restart help
e50e472
Merge origin/dev into fix/codex-restart-app-server
lidge-jun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Complete the restrictive negation.
The phrase
n'est quittée puis relancée entièrement siis incomplete for “only when.” Replace it withn'est entièrement quittée puis relancée que si. LanguageTool also flags this incomplete negation.🧰 Tools
🪛 LanguageTool
[style] ~356-~356: Cette structure peut être modifiée afin de devenir plus percutante.
Context: ...tion Codex. L'application Codex Desktop n'est quittée puis relancée entièrement si el...
(NEGATION_INCOMPLETE)
[typographical] ~356-~356: Caractère d’apostrophe incorrect.
Context: ... un sélecteur à jour reste ouverte avec
desktopApp.reason: "picker_current". Une application fermée renvoie `deskto...(APOS_INCORRECT)
[typographical] ~356-~356: Caractère d’apostrophe incorrect.
Context: ...targets"
; sonpickerStatepeut êtrenot_running, oustale` si cette requête a changé l...(APOS_INCORRECT)
[typographical] ~356-~356: Caractère d’apostrophe incorrect.
Context: ...quête a changé la liaison au catalogue.
desktopApp.pickerStateindique la lectu...(APOS_INCORRECT)
[typographical] ~356-~356: Caractère d’apostrophe incorrect.
Context: ...rState
indique la lecture qui a décidé (current,stale,unknownounot_run...(APOS_INCORRECT)
[typographical] ~356-~356: Caractère d’apostrophe incorrect.
Context: ...que la lecture qui a décidé (
current,stale,unknownounot_running). Lorsque l...(APOS_INCORRECT)
[typographical] ~356-~356: Caractère d’apostrophe incorrect.
Context: ...écidé (
current,stale,unknownounot_running). Lorsque le proxy lui-même s'exécute d...(APOS_INCORRECT)
🤖 Prompt for AI Agents
Source: Linters/SAST tools